[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] nbd-server: fix parse_cfile() to not modify any global variables



On Sat, Jan 05, 2013 at 11:39:26AM +0200, Tuomas Jorma Juhani Räsänen wrote:
> On Sat, Jan 05, 2013 at 02:12:34AM +0100, Wouter Verhelst wrote:
> > Thanks, I've applied all four, but applied one on top that removes the
> > g_free() calls again. I've thought about it a bit more, and consider
> > that to be the better approach.
> > 
> 
> Ok.
> 
> > The commit message includes some more explanations, including some that
> > weren't in the thread here.
> > 
> 
> I can't understand how on earth I managed to leave out pointer
> nullifying.. been too long on vacation, too much chocolate in my
> blood, wrong colored socks... oh well.

Well, that's why there's review :-)

-- 
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.



Reply to: