Re: [Nbd] [PATCH] nbd: correct disconnect behavior
- To: Rob Landley <rob@...1361...>
- Cc: nbd-general@lists.sourceforge.net, Andrew Morton <akpm@...133...>, linux-kernel@...25...
- Subject: Re: [Nbd] [PATCH] nbd: correct disconnect behavior
- From: Pavel Machek <pavel@...28...>
- Date: Mon, 26 Aug 2013 14:54:59 +0200
- Message-id: <20130826125459.GB20329@...1383...>
- In-reply-to: <1372749578.5019.8@...1362...>
- References: <20130626162107.9237360f7646ec25f23cf5aa@...133...> <1372749578.5019.8@...1362...>
Hi!
> >> --- a/include/linux/nbd.h
> >> +++ b/include/linux/nbd.h
> >> @@ -41,6 +41,7 @@ struct nbd_device {
> >> u64 bytesize;
> >> pid_t pid; /* pid of nbd-client, if attached */
> >> int xmit_timeout;
> >> + int disconnect; /* a disconnect has been requested by user */
> >> };
> >
> >The cool kids are using bool lately ;)
>
> No, they're not. The C++ guys and stuffy old ex-cobol types are, and
> think it helps. (Does any architecture anywhere _not_ use int for
> bool?)
Its useful as documentation, and while it is probably int,
faster/smaller code can probably generated in some cases.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Reply to: