[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] nbd: correct disconnect behavior



Hi!

> >> --- a/include/linux/nbd.h
> >> +++ b/include/linux/nbd.h
> >> @@ -41,6 +41,7 @@ struct nbd_device {
> >>  	u64 bytesize;
> >>  	pid_t pid; /* pid of nbd-client, if attached */
> >>  	int xmit_timeout;
> >> +	int disconnect; /* a disconnect has been requested by user */
> >>  };
> >
> >The cool kids are using bool lately ;)
> 
> No, they're not. The C++ guys and stuffy old ex-cobol types are, and
> think it helps. (Does any architecture anywhere _not_ use int for
> bool?)

Its useful as documentation, and while it is probably int,
faster/smaller code can probably generated in some cases.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



Reply to: