Re: [Nbd] [PATCH] nbd: clean disconnect from NBD_DO_IT
- To: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH] nbd: clean disconnect from NBD_DO_IT
- From: Michal Belczyk <belczyk@...1274...>
- Date: Tue, 18 Jun 2013 21:36:12 +0200
- Message-id: <20130618193612.GE64329@...1273...>
- In-reply-to: <51C089CB.4090508@...112...>
- References: <CAECXXi7Xgj99-s-upgO=vUgO3uhTZLC7enmxccNLGyc9bDGpbA@...18...> <51C089CB.4090508@...112...>
On Tue, Jun 18, 2013 at 06:24:43PM +0200, Wouter Verhelst wrote:
> On 18-06-13 16:13, Paul Clements wrote:
> > This one has been discussed a number of times, and I've finally gotten
> > around to doing it. The problem is that NBD_DO_IT does not always return
> > cleanly (with return code 0) when a disconnect is requested by the user.
> > This patch fixes that so that nbd-client can correctly quit, even in
> > persist mode, when the user asks for a disconnect.
> >
> > Comments? If this looks useful to people, then I'll push it upstream.
> >
> > There is a larger, somewhat related change that I'm working on too,
> > which will allow for a clean reconnect after network failure (instead of
> > getting I/O errors).
>
> Looks good to me...
+1
--
Michal Belczyk Sr.
Reply to: