Re: [Nbd] [PATCH] nbd: remove false assertion
- To: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH] nbd: remove false assertion
- From: Wouter Verhelst <w@...112...>
- Date: Tue, 18 Jun 2013 09:02:03 +0200
- Message-id: <51C005EB.1060005@...112...>
- In-reply-to: <20130617205505.GC64329@...1273...>
- References: <20130616205902.GA64268@...1273...> <CAECXXi7Qd3iUFMNNRxEmOMoZRpP=fnr1+apwoR4ekhhkRy6VDg@...18...> <51BF7454.1050703@...112...> <20130617205505.GC64329@...1273...>
On 17-06-13 22:55, Michal Belczyk wrote:
> On Mon, Jun 17, 2013 at 10:40:52PM +0200, Wouter Verhelst wrote:
>> On 17-06-13 22:21, Paul Clements wrote:
>>> Also, we should be pulling the NBD_CLEAR_QUE calls out of user-level
>>> code. I'm surprised it's still in there.
>>
>> Nobody ever told me to remove it (at least not that I remember)
>>
>> I've just committed a change that removes it from nbd-client.
>
> There is one more call to this ioctl()...
Oops
> The code has been there for ages -- nobody expects you to commit changes in 5
> minutes... ;-)
Yes, well, the code is fairly trivial, it shouldn't have been difficult...
--
This end should point toward the ground if you want to go to space.
If it starts pointing toward space you are having a bad problem and you
will not go to space today.
-- http://xkcd.com/1133/
Reply to: