[Nbd] [PATCH 3/3] nbd-server: const'd function parameter variable
- To: nbd-general@lists.sourceforge.net
- Subject: [Nbd] [PATCH 3/3] nbd-server: const'd function parameter variable
- From: Tuomas Räsänen <tuomasjjrasanen@...1261...>
- Date: Tue, 11 Jun 2013 18:49:58 +0300
- Message-id: <5d1195eee36d471e135682ab04f340b9d74dbd18.1370964005.git.tuomasjjrasanen@...1261...>
- In-reply-to: <7b76c32ad2b6d9eb44d75176417e37f187456ec4.1370964005.git.tuomasjjrasanen@...1261...>
- References: <7b76c32ad2b6d9eb44d75176417e37f187456ec4.1370964005.git.tuomasjjrasanen@...1261...>
Making the parameter variable const revealed a smelly assignment
statement which was deemed unnecessary and hence removed.
Signed-off-by: Tuomas Räsänen <tuomasjjrasanen@...1261...>
---
nbd-server.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/nbd-server.c b/nbd-server.c
index 34b064e..1cd25bc 100644
--- a/nbd-server.c
+++ b/nbd-server.c
@@ -2354,7 +2354,7 @@ handler_err:
}
static void
-handle_oldstyle_connection(GArray *servers, SERVER *serve)
+handle_oldstyle_connection(GArray *const servers, SERVER *const serve)
{
int net;
CLIENT *client = NULL;
@@ -2427,8 +2427,7 @@ handle_oldstyle_connection(GArray *servers, SERVER *serve)
g_hash_table_destroy(children);
children = NULL;
for(i=0;i<servers->len;i++) {
- serve=&g_array_index(servers, SERVER, i);
- close(serve->socket);
+ close(g_array_index(servers, SERVER, i).socket);
}
/* FALSE does not free the
actual data. This is required,
--
1.7.10.4
Reply to: