[Nbd] [PATCH 5/5] nbd-server: const'd function parameter variables
- To: nbd-general@lists.sourceforge.net
- Subject: [Nbd] [PATCH 5/5] nbd-server: const'd function parameter variables
- From: Tuomas Räsänen <tuomasjjrasanen@...1261...>
- Date: Wed, 5 Jun 2013 20:43:12 +0300
- Message-id: <5825077e778a8e9675f1e00c2f5d6494045a8cc8.1370452657.git.tuomasjjrasanen@...1261...>
- In-reply-to: <60658c7c00129387875f3fdaf08441b89fa4ad8c.1370452657.git.tuomasjjrasanen@...1261...>
- References: <60658c7c00129387875f3fdaf08441b89fa4ad8c.1370452657.git.tuomasjjrasanen@...1261...>
Making the parameter variable const revealed a smelly assignment
statement which was deemed unnecessary and hence removed.
Signed-off-by: Tuomas Räsänen <tuomasjjrasanen@...1261...>
---
nbd-server.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/nbd-server.c b/nbd-server.c
index d7d9c62..d783051 100644
--- a/nbd-server.c
+++ b/nbd-server.c
@@ -2354,7 +2354,7 @@ handler_err:
}
static void
-handle_oldstyle_connection(GArray *servers, SERVER *serve)
+handle_oldstyle_connection(GArray *const servers, SERVER *const serve)
{
int net;
CLIENT *client = NULL;
@@ -2427,8 +2427,7 @@ handle_oldstyle_connection(GArray *servers, SERVER *serve)
g_hash_table_destroy(children);
children = NULL;
for(i=0;i<servers->len;i++) {
- serve=&g_array_index(servers, SERVER, i);
- close(serve->socket);
+ close(g_array_index(servers, SERVER, i).socket);
}
/* FALSE does not free the
actual data. This is required,
--
1.7.10.4
Reply to: