Re: [Nbd] NBD, DISCARD/TRIM
- To: Wouter Verhelst <w@...112...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] NBD, DISCARD/TRIM
- From: Alex Bligh <alex@...872...>
- Date: Sat, 30 Mar 2013 14:15:17 +0000
- Message-id: <55B3C25C-7E05-4488-8F96-8D1268CC12B4@...872...>
- In-reply-to: <5156D43A.5000706@...112...>
- References: <CAECXXi5N6RpC8=YcWFaiwH2oBA8aJHRvcwLJg_Hw14ESL1+bnA@...18...> <CAECXXi6G3ydMAvjP1fHJJ-Jn_6e3GQO51XiVy4jpXv1yu2X1jw@...18...> <20130322212454.GC19387@...855...> <CAECXXi6V+onKJjR+NZ0nDLHtXze2tTeQZdPHYX8rozB06-C+bg@...18...> <20130325192620.GF32435@...855...> <CAECXXi5sMNO7GFeicPh9JPtNk7tMSPoXH_14eOtbns+ik5eX8w@...18...> <20130325204900.GH32435@...855...> <CAECXXi7O2JDfMJ6-8oio6ykoximBP4+KtfPjX6ATgt84rW4FjQ@...18...> <20130327204914.GT32435@...855...> <CAECXXi6LQ0oLWV3WvWDmiN1pDUEyHEfpn4jfmzh--PpMYXLfSQ@...18...> <20130328163642.GY32435@...855...> <CAECXXi7=Nh6jwF3w6d7kEJR4W37gqUjdmOsaGRtdvdHcc6S-fg@...18...> <5155BAC2.9080407@...112...> <5155D045.7070200@...112...> <511EE2C6-C8FB-4C40-BA99-10939C5ACEB0@...872...> <5156D43A.5000706@...112...>
On 30 Mar 2013, at 12:02, Wouter Verhelst wrote:
>>
>> However, if you ever want to be able to receive signals and process them
>> (e.g. to dump some stats) you are going to have to deal with ERESTARTSYS
>> or EAGAIN anyway. I think I'd rather do that and avoid the fragility.
>
> We can't do that in nbd-client -- at least not unless the API is changed
> away from the NBD_DO_IT ioctl (Note that I'm not advocating that).
Oh, yes nbd-*client* (duh). I think there before going into the ioctl we
should simply mask off all signals we don't want to process, which would
I think be everything except those designed to kill the process. IE we
should mask off HUP etc. too, just in case someone foolishly sends it one.
--
Alex Bligh
Reply to:
- References:
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Paul Clements <paul.clements@...856...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Paul Clements <paul.clements@...856...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: folkert <folkert@...421...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Paul Clements <paul.clements@...856...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: folkert <folkert@...421...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Paul Clements <paul.clements@...856...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: folkert <folkert@...421...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Paul Clements <paul.clements@...856...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: folkert <folkert@...421...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Paul Clements <paul.clements@...856...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: folkert <folkert@...421...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Paul Clements <paul.clements@...856...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Wouter Verhelst <w@...112...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Wouter Verhelst <w@...112...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Alex Bligh <alex@...872...>
- Re: [Nbd] NBD, DISCARD/TRIM
- From: Wouter Verhelst <w@...112...>