Re: [Nbd] [PATCH 1/1] server: remove non-reachable call to err()
- To: folkert <folkert@...421...>
- Cc: nbd-general@lists.sourceforge.net, Tuomas R?s?nen <tuomasjjrasanen@...1258...>
- Subject: Re: [Nbd] [PATCH 1/1] server: remove non-reachable call to err()
- From: Wouter Verhelst <w@...112...>
- Date: Tue, 12 Mar 2013 01:37:03 +0100
- Message-id: <20130312003703.GA5305@...3...>
- In-reply-to: <20130311200755.GK1911@...855...>
- References: <4872930b34a4b68d73810e4e31f9fa0d522e0aac.1362947875.git.tuomasjjrasanen@...1261...> <20130310211507.GA23754@...3...> <20130310213810.GA22370@...1259...> <20130311200755.GK1911@...855...>
On Mon, Mar 11, 2013 at 09:07:55PM +0100, folkert wrote:
> > > Mmm. Checking for programmer error isn't necessarily a bad idea, though.
> > > Yes, it's best done at compile time, but that isn't always possible.
> > >
> > > Perhaps change it into an assert() instead?
> >
> > Very well, assert() might be a good idea and I even thought it for a
> > second or two, but then the pedantic side of me took
> > over. Assert-statements do burn my eyes, you know. But that should be
> > easily fixed by wearing PRAGMATISM-protective glasses more often while
> > coding.
>
> Didn't use asserts use cpu-time? E.g. aren't they also executed in
> non-debug mode?
Not if you use -DNDEBUG; in that case, assert() expands to nothing.
(there are some arguments against using NDEBUG, but that's besides the point
here)
--
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.
Reply to: