[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] BUG: debug output uses signed integer for length field



On Tue, Mar 05, 2013 at 10:19:39AM +0100, folkert wrote:
> Replaced %d by %u.

applied.
> diff -uNrBbd nbd-3.2.org/nbd-server.c nbd-3.2/nbd-server.c
> --- nbd-3.2.org/nbd-server.c	2012-07-03 22:54:53.000000000 +0200
> +++ nbd-3.2/nbd-server.c	2013-03-05 10:04:41.000000000 +0100
> @@ -1736,9 +1736,9 @@
>  		command = request.type & NBD_CMD_MASK_COMMAND;
>  		len = ntohl(request.len);
>  
> -		DEBUG("%s from %llu (%llu) len %d, ", getcommandname(command),
> +		DEBUG("%s from %llu (%llu) len %u, ", getcommandname(command),
>  				(unsigned long long)request.from,
> -				(unsigned long long)request.from / 512, (unsigned int)len);
> +				(unsigned long long)request.from / 512, len);
>  
>  		if (request.magic != htonl(NBD_REQUEST_MAGIC))
>  			err("Not enough magic.");
> 
> 
> Folkert van Heusden
> 
> -- 
> MultiTail is a versatile tool for watching logfiles and output of
> commands. Filtering, coloring, merging, diff-view, etc.
> http://www.vanheusden.com/multitail/
> ----------------------------------------------------------------------
> Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
> 
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_feb
> _______________________________________________
> Nbd-general mailing list
> Nbd-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nbd-general
> 

-- 
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.



Reply to: