Re: [Nbd] nbd-client current tip does not compile...
- To: Michal Belczyk <belczyk@...1274...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] nbd-client current tip does not compile...
- From: Wouter Verhelst <w@...112...>
- Date: Thu, 14 Feb 2013 10:51:06 +0100
- Message-id: <20130214095106.GA28155@...3...>
- In-reply-to: <20130213210008.GA53590@...1273...>
- References: <20130213210008.GA53590@...1273...>
On Wed, Feb 13, 2013 at 10:00:08PM +0100, Michal Belczyk wrote:
> Hi,
>
> it looks like this commit
>
> https://github.com/yoe/nbd/commit/c50a67520e6fb473eac298c89b8a408a380cfbb4
>
> broke the current tip.
>
> Please consider applying the following change:
>
> diff --git a/nbd-client.c b/nbd-client.c
> index 83a68f8..b40c34d 100644
> --- a/nbd-client.c
> +++ b/nbd-client.c
> @@ -283,7 +283,7 @@ void negotiate(int sock, u64 *rsize64, u32 *flags, char* name, uint32_t needed_f
> err("Not enough cliserv_magic");
> else
> err("It looks like you're trying to connect to a newstyle server with the oldstyle protocol. Try the -N option.");
> - printf(".");
> + }
> }
That printf shouldn't be removed, it's still useful. Other than that, thanks, applied.
> Thanks!
>
> PS: I really didn't want my first post on this mailing list to be a bug report! ;-)
Heh. No problem :-)
--
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.
Reply to: