Re: [Nbd] [PATCH 4/5] nbd-server: remove commented code

[Wouter Verhelst <w@...112...>]

Yes, indeed, doesn't make much sense that way. Applied, thanks.

On Fri, Jan 11, 2013 at 11:54:50PM +0200, Tuomas Jorma Juhani Räsänen wrote:
> Signed-off-by: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
> ---
>  nbd-server.c |   10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/nbd-server.c b/nbd-server.c
> index be65ebb..2ba55f5 100644
> --- a/nbd-server.c
> +++ b/nbd-server.c
> @@ -2352,8 +2352,6 @@ int dosockopts(const int socket, GError **const gerror) {
>  #endif /* sun */
>  	struct linger l;
>  
> -	//int sock_flags;
> -
>  	/* lose the pesky "Address already in use" error message */
>  	if (setsockopt(socket,SOL_SOCKET,SO_REUSEADDR,&yes,sizeof(int)) == -1) {
>                  g_set_error(gerror, SETUP_ERROR, SETUP_ERROR_SO_REUSEADDR,
> @@ -2376,14 +2374,6 @@ int dosockopts(const int socket, GError **const gerror) {
>                  return -1;
>  	}
>  
> -	/* make the listening socket non-blocking */
> -	/*if ((sock_flags = fcntl(socket, F_GETFL, 0)) == -1) {
> -		err("fcntl F_GETFL");
> -	}
> -	if (fcntl(socket, F_SETFL, sock_flags | O_NONBLOCK) == -1) {
> -		err("fcntl F_SETFL O_NONBLOCK");
> -	}*/
> -
>          return 0;
>  }
>  
> -- 
> 1.7.10.4
> 
> 
> ------------------------------------------------------------------------------
> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
> much more. Get web development skills now with LearnDevNow -
> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122812
> _______________________________________________
> Nbd-general mailing list
> Nbd-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nbd-general

-- 
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.