Re: [Nbd] [PATCH 4/4] nbd-server: remove global variables: modern_listen and modernport
- To: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH 4/4] nbd-server: remove global variables: modern_listen and modernport
- From: Wouter Verhelst <w@...112...>
- Date: Sat, 5 Jan 2013 02:02:33 +0100
- Message-id: <20130105010233.GE13332@...3...>
- In-reply-to: <20130104204157.GA2627@...1259...>
- References: <20130103212115.GA5115@...1259...> <20130104014059.GH2976@...3...> <20130104131009.GC13314@...1259...> <20130104151243.GA18868@...3...> <20130104204157.GA2627@...1259...>
On Fri, Jan 04, 2013 at 10:41:57PM +0200, Tuomas Jorma Juhani Räsänen wrote:
> So, when writing this (or the other) patch, I didn't want to think too
> much how the username or the groupname could be exploited in future. I
> just tried to create a patch which would be correct on its own without
> any requirements for the future.
Still, I'm not of the opinion that not free()ing data until program end
is wrong, _provided that you don't re-assign that value over and over
and over again_.
Technically that's a memory leak, yes, but not one that matters much.
Anyway, it's not all that important, I suppose.
--
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.
Reply to: