[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH 2/2] nbd-server: remove unused CFILE_ -error codes



On Mon, Dec 31, 2012 at 10:01:31AM +0100, Wouter Verhelst wrote:
> 
> NAK, sorry. The fact that these aren't used doesn't mean we need to
> remove them, it means we may need to add checks -- unless you have a
> good argument why they don't make sense?
> 

No problem. I think it's a matter of taste. I am used to keeping
source code free of unreferenced code. But I can see your point in
keeping these hanging around, as reminders, until the corresponding
test is implemented.

Either way, it isn't biggie.

-- 
Tuomas



Reply to: