Re: [Nbd] [PATCH] nbd-server: remove unused function serve_err()
- To: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH] nbd-server: remove unused function serve_err()
- From: Wouter Verhelst <w@...112...>
- Date: Sat, 29 Dec 2012 12:42:59 +0100
- Message-id: <20121229114259.GK30316@...3...>
- In-reply-to: <20121228132317.GA15987@...1259...>
- References: <20121228132317.GA15987@...1259...>
On Fri, Dec 28, 2012 at 03:23:17PM +0200, Tuomas Jorma Juhani Räsänen wrote:
> Error reporting and handling should be streamlined. Currently there are
> quite many different ways errors are being logged, reported and handled.
>
> This shall be the first baby step towards more uniform error management.
>
> Signed-off-by: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
> ---
> nbd-server.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/nbd-server.c b/nbd-server.c
> index ec617a9..ca861ed 100644
> --- a/nbd-server.c
> +++ b/nbd-server.c
> @@ -2535,14 +2535,6 @@ void daemonize(SERVER* serve) {
> * The stuff above daemonize() isn't.
> */
>
> -void serve_err(SERVER* serve, const char* msg) G_GNUC_NORETURN;
> -
> -void serve_err(SERVER* serve, const char* msg) {
> - g_message("Export of %s on port %d failed:", serve->exportname,
> - serve->port);
> - err(msg);
> -}
> -
> /**
> * Set up user-ID and/or group-ID
> **/
> --
> 1.7.10.4
Good catch. Applied, thanks.
--
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.
Reply to: