[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [RFC PATCH] nbd-server: set supplementary groups by default when changing UID/GID

On Mon, Jun 25, 2012 at 03:32:55AM +0400, Dmitry V. Levin wrote:
> Before this change, there was no way to clear or change supplementary
> groups at all, which is usually required to be done along with changing
> UID and GID.  This change introduces a new global config boolean option
> "setgroups" and enables it by default.  When this option is set to true,
> - "group" option will additionally clear the list of supplementary groups;

This is sensible, I suppose.

> - unless "group" option is specified, "user" option will additionally
>   change both GID and the list of supplementary groups to those defined
>   by the given user name.

I'm not sure about that one; I think setting a group based on an option
called "user" -- if there is no option "group" specified -- is going to
be counterintuitive.

Instead, it might be better to redefine the "group" option as a
comma-separated list, so that multiple groups can be set in the
configuration file, if needs be.

The volume of a pizza of thickness a and radius z can be described by
the following formula:

pi zz a

Reply to: