[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] 3.1 released

On Tue, May 15, 2012 at 10:20:10AM +0200, Wouter Verhelst wrote:
> Hi folks,
> So, since there wasn't much response on my request for review, I've
> assumed that I did everything right... we'll see.

Okay, so that didn't turn out to be the case:

diff --git a/nbd-client.c b/nbd-client.c
index 4338bf5..0e62821 100644
--- a/nbd-client.c
+++ b/nbd-client.c
@@ -432,7 +432,7 @@ int main(int argc, char *argv[]) {
        int c;
        int nonspecial=0;
        char* name=NULL;
-       uint32_t needed_flags;
+       uint32_t needed_flags=0;
        uint32_t cflags;
        uint32_t opts;
        struct option long_options[] = {

I didn't notice, since on my system that needed_flags variable just
happens to be initialized to zero, but of course you can't depend on

Silly me.

The volume of a pizza of thickness a and radius z can be described by
the following formula:

pi zz a

Reply to: