Re: [Nbd] [PATCH] Add transaction log support and integrity test
- To: Wouter Verhelst <w@...112...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH] Add transaction log support and integrity test
- From: Alex Bligh <alex@...872...>
- Date: Fri, 27 May 2011 17:57:54 +0100
- Message-id: <41CF6BAA04CAA3A663A49EBD@...873...>
- Reply-to: Alex Bligh <alex@...872...>
- In-reply-to: <20110527165115.GB24216@...510...>
- References: <1305965916-12502-1-git-send-email-alex@...872...> <20110527165115.GB24216@...510...>
Wouter,
--On 27 May 2011 18:51:15 +0200 Wouter Verhelst <w@...112...> wrote:
e) if we're going to test a server's functionality, it's generally a
good idea not to generate data for that test by the same (possibly
broken) implementation of that server itself (even if it is highly
unlikely for wrong data to cause the test to produce a false
positive, as is the case here).
Indeed :-) Thanks for that and the pull. I should have some time to
look at it this weekend.
I was planning to add an option to connect via a UNIX domain socket.
On most architectures this restricts the server and client to the same
server, which at first doesn't seem very useful, but it's useful for
debugging what portion is impacted by speed delay. Is this too arcane
to be accepted (assume I will do it competently and non-intrusively).
--
Alex Bligh
Reply to: