Re: [Nbd] [PATCH] add support for NBD_CMD_TRIM, update docs

[Wouter Verhelst <w@...112...>]

On Thu, Sep 08, 2011 at 06:38:13PM +0200, Wouter Verhelst wrote:
> On Thu, Sep 08, 2011 at 12:05:46PM +0200, Paolo Bonzini wrote:
> > +		case NBD_CMD_TRIM:
> > +			/* The kernel module sets discard_zeroes_data == 0,
> > +			 * so it is okay to do nothing.  */
> 
> except it would be nice to implement this anyway, so we can use
> FALLOCATE_PUNCH_HOLE (or what was it called again).
> 
> I did look into this in the past, but since the necessary kernel-side
> stuff hadn't been done yet, did not spend too much time looking into it.

Forgot to mention:

thanks, applied

;-)

-- 
The volume of a pizza of thickness a and radius z can be described by
the following formula:

pi zz a