Re: [Nbd] [PATCH 2/3] nbd: add support for feature negotiation
- To: Paolo Bonzini <pbonzini@...696...>
- Cc: nbd-general@lists.sourceforge.net, linux-api@...25..., linux-kernel@...25...
- Subject: Re: [Nbd] [PATCH 2/3] nbd: add support for feature negotiation
- From: Paul Clements <paul.clements@...856...>
- Date: Wed, 7 Sep 2011 17:54:01 -0400
- Message-id: <CAECXXi6NO1gvmREr_31ve-k67fsirqerdm7=ZX0tYqx+Yj52Sw@...18...>
- In-reply-to: <4E67AF6A.9090400@...696...>
- References: <1315406503-7883-1-git-send-email-pbonzini@...696...> <1315406503-7883-3-git-send-email-pbonzini@...696...> <CAECXXi4YW++_302mcSTX=cPjbguSqcw3Weec85VrLFv1qNHXug@...18...> <4E67AF6A.9090400@...696...>
On Wed, Sep 7, 2011 at 1:52 PM, Paolo Bonzini <pbonzini@...696...> wrote:
> On 09/07/2011 06:30 PM, Paul Clements wrote:
>>
>> Could you name this as NBD_SET_FLAGS, as that's more consistent with
>> what it's really doing?
>
> I named it differently intentionally, actually, because it should not use
> the flags field from the network protocol as is. Also, "features" sounds
> more like something that is optional, while unrecognized "flags" should
> probably cause a failure.
Alright, I can buy that argument -- I don't feel that strongly about it...
This looks good to me, then.
--
Paul
Reply to: