Re: [Nbd] [PATCH] Only send one reply on oversize writes

[Wouter Verhelst <w@...112...>]

On Sun, May 29, 2011 at 10:02:36AM +0100, Alex Bligh wrote:
> Wouter,
> 
> --On 29 May 2011 09:17:48 +0200 Wouter Verhelst <w@...112...> wrote:
> 
> >> You will be pleased to hear I don't plan to do anything more for
> >> this weekend's release, unless you find some bugs in my code of
> >> course.
> >
> > I didn't see anything suspicious in your code, so I've merged it. I'm
> > working on the release right now.
> 
> Thanks, but that clearly jinxed it:
> 
> > Scratch that, it doesn't work if you do --enable-syslog (because
> > nbd-trdump.c doesn't #include <syslog.h>) nbd-trdump). I've committed a
> > fix for that, will upload fixed files in a minute (once 'make distcheck'
> > finishes).
> 
> Sorry about that. My excuse for today is that cliserv.h is a bit of
> a hotch-potch - 

It is; it's the one thing I never got around to cleaning up after I took
over maintainership.

> I'd never imagined it would be calling syslog etc.
> If it is going to call syslog (i.e. if that define is set), it should
> probably '#include <syslog.h>' itself rather than hoping the file
> including cliserv.h does that too.

Yeah, probably. On the other hand, there's no point for nbd-trdump to
write anything to syslog, so this #undef is probably a good idea at any
rate.

-- 
The volume of a pizza of thickness a and radius z can be described by
the following formula:

pi zz a