Re: [Nbd] [PATCH] Add nbd-trdump manpage

[Wouter Verhelst <w@...112...>]

Hi Alex,

On Sat, May 28, 2011 at 09:22:55AM +0100, Alex Bligh wrote:
> This patch adds an nbd-trdump manpage, which will be useful if
> Wouter can persuade automake to build it during a default make,
> and thus get it installed.
> 
> Available from git.alex.org.uk as usual.
> 
> Signed-off-by: Alex Bligh <alex@...872...>
> ---
>  autogen.sh               |    2 +-
>  configure.ac             |    2 +-
>  man/Makefile.am          |   16 ++++++++++++----
>  man/nbd-server.1.in.sgml |    2 +-
>  man/nbd-server.5.in.sgml |    2 +-
>  5 files changed, 16 insertions(+), 8 deletions(-)
> 
> diff --git a/autogen.sh b/autogen.sh
> index 2d041fd..0719077 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -1,4 +1,4 @@
>  #!/bin/sh
>  set -ex
> -make -C man -f Makefile.am nbd-server.1.sh.in nbd-server.5.sh.in nbd-client.8.sh.in
> +make -C man -f Makefile.am nbd-server.1.sh.in nbd-server.5.sh.in nbd-client.8.sh.in nbd-trdump.8.sh.in
>  exec autoreconf -f -i
> diff --git a/configure.ac b/configure.ac
> index cff4928..6ebfa1a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -123,6 +123,6 @@ AC_TYPE_PID_T
>  nbd_server_CPPFLAGS=$nbd_server_CPPFLAGS" -DSYSCONFDIR='\"$sysconfdir\"'"
>  AC_SUBST(nbd_server_CPPFLAGS)
>  AC_CONFIG_HEADERS([config.h])
> -AC_CONFIG_FILES([Makefile doc/Doxyfile man/Makefile man/nbd-client.8.sh man/nbd-server.5.sh man/nbd-server.1.sh])
> +AC_CONFIG_FILES([Makefile doc/Doxyfile man/Makefile man/nbd-client.8.sh man/nbd-server.5.sh man/nbd-server.1.sh man/nbd-trdump.8.sh])

I had automake put nbd-trdump in .../bin, which would make it a user
command, not a sysadmin one. That would mean it would need to be put in
man section 1, not 8.

I'll fix that after I merge your patch, should be easy. Thanks for this
:-)

-- 
The volume of a pizza of thickness a and radius z can be described by
the following formula:

pi zz a