[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] Problems in negotiating modern handshake



Wouter,


>>                client->net = net;
>>                client->modern = TRUE;
>> -                free(name);
>> -                return client;
>> +                break;
> 
> You've removed a return statement here. Are you sure that's not the
> problem?

Any NULL return causes the SEGV. I don't think you want to return here, or if you have found the server, you don't send the flags and the 124 bytes of zeroes (the bit marked "common"), etc.

-- 
Alex Bligh


Reply to: