Re: [Nbd] Problems in negotiating modern handshake
- To: Wouter Verhelst <w@...112...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>
- Subject: Re: [Nbd] Problems in negotiating modern handshake
- From: Alex Bligh <alex@...872...>
- Date: Tue, 17 May 2011 08:48:12 +0100
- Message-id: <BC88A979-7D90-4627-92FE-A5FD5F3D0874@...872...>
- In-reply-to: <20110517073208.GA19004@...510...>
- References: <F2601443AABCE0937229C4A6@...873...> <20110517073208.GA19004@...510...>
Wouter,
>> client->net = net;
>> client->modern = TRUE;
>> - free(name);
>> - return client;
>> + break;
>
> You've removed a return statement here. Are you sure that's not the
> problem?
Any NULL return causes the SEGV. I don't think you want to return here, or if you have found the server, you don't send the flags and the 124 bytes of zeroes (the bit marked "common"), etc.
--
Alex Bligh
Reply to: