Re: [Nbd] nbd: Oops because nbd doesn't prevent NBD_CLEAR_SOCK while sock_xmit() is working on a receive
- To: Mike Snitzer <snitzer@...17...>
- Cc: nbd-general@lists.sourceforge.net, linux-kernel@...25...
- Subject: Re: [Nbd] nbd: Oops because nbd doesn't prevent NBD_CLEAR_SOCK while sock_xmit() is working on a receive
- From: Paul Clements <paul.clements@...124...>
- Date: Thu, 27 Mar 2008 23:17:39 -0400
- Message-id: <47EC6353.1080602@...124...>
- In-reply-to: <170fa0d20803271412i6d7dd81ax41e0f77339b5def7@...18...>
- References: <170fa0d20803261143s1ab258b2ra470c158ac5744a@...18...> <47EB94AB.6090608@...124...> <170fa0d20803270621k7723ae47n337011beafe87cdb@...18...> <170fa0d20803271412i6d7dd81ax41e0f77339b5def7@...18...>
Mike Snitzer wrote:
With the nbd_sock_xmit_oops.patch applied this Oops no longer happens.
I think my original patch's use of EINVAL should be changed to EIO.
Any other comments on the fix are welcome.
No, EINVAL is fine, so the original patch looks good to me.
Paul, would you like an updated patch that you push upstream? Or
should I just submit the patch and Cc: you?
The original one is fine, go ahead and send it.
Thanks,
Paul
Reply to: