Re: [Nbd] [PATCH 1/1] NBD: add partition support

[Laurent Vivier <Laurent.Vivier@...154...>]

Hi Bogdan,

Le jeudi 10 avril 2008 à 11:42 +0200, Bogdan Harjoc a écrit :
> I was convinced I'd sent a similar (but more naive) patch for this
> about
> two years ago to nbd-general. Now that I searched through my folders, 
> it seems I'd only sent it to Wouter.

In my "long" experience, I learned that the best patch will never be
included if you don't send it to the good people ;-)
(Well, it's also true for the worst patches...)

> Most things are handled better by Laurent's version, with the
> exception
> (IMO) that GENHD_FL_SUPPRESS_PARTITION_INFO is being removed
> permanently in his, whereas I only remove it before nbd_do_it() and
> re-add
> it afterwards. I'm attaching my version here. 

I don't understand why you do that ?

Regards,
Laurent

> Cheers,
> Bogdan
> 
> On Wed, Apr 2, 2008 at 3:44 PM, Wouter Verhelst <w@...112...> wrote:
>         On Tue, Apr 01, 2008 at 05:14:09PM -0400, Paul Clements wrote:
>         > Below, Laurent notes that partition table re-read doesn't
>         automatically
>         > occur. For now you'll have to open("/dev/nbdX") to get that
>         to happen.
>         > Longer term, nbd-client can be modified to fork just before
>         nbd_do_it()
>         > and then call ioctl(BLKRRPART, "/dev/nbdX") in the parent
>         process
>         > (probably need to wait for the "pid" file to show up in /sys
>         to avoid a
>         > race).
>         
>         
>         I just released nbd-2.9.10, which does just that.
>         
>         --
>         <Lo-lan-do> Home is where you have to wash the dishes.
>          -- #debian-devel, Freenode, 2004-09-22
>         
>         -------------------------------------------------------------------------
>         Check out the new SourceForge.net Marketplace.
>         It's the best place to buy or sell services for
>         just about anything Open Source.
>         http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
>         _______________________________________________
>         Nbd-general mailing list
>         Nbd-general@lists.sourceforge.net
>         https://lists.sourceforge.net/lists/listinfo/nbd-general
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________ Nbd-general mailing list Nbd-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nbd-general
-- 
------------- Laurent.Vivier@...154... ---------------
"The best way to predict the future is to invent it."
- Alan Kay