[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] Specifying interface to listen on



On Thu, Sep 27, 2007 at 12:41:28PM +0200, Wouter Verhelst wrote:
> On Thu, Sep 27, 2007 at 12:10:34PM +0200, Tefnet Developers wrote:
> > @@ -1443,7 +1457,12 @@
> >  	DEBUG("Waiting for connections... bind, ");
> >  	addrin.sin_family = AF_INET;
> >  	addrin.sin_port = htons(serve->port);
> > -	addrin.sin_addr.s_addr = 0;
> > +
> > +	hen=gethostbyname(serve->host);

Thinking a bit further about this patch, I'm also not entirely convinced
that "host" is an appropriate name for this concept. I associate that
with things like "the remote host we're listening to", rather than "the
local IP address we're listening on". Please also consider that in an
updated patch.

-- 
<Lo-lan-do> Home is where you have to wash the dishes.
  -- #debian-devel, Freenode, 2004-09-22



Reply to: