Re: [Nbd] [patch] fix "copy on write" wrong code

[Wouter Verhelst <wouter@...3...>]

On Fri, Oct 21, 2005 at 08:53:32AM +0400, Maxim Syrchin wrote:
> Wouter Verhelst wrote:
> >>- wrong place for initialisation of diffmaps
> >>   
> >>
> >
> >Well -- what's "wrong" is just a matter of opinion here, I'd say. It's
> >both initialization code...
> >
> At does not work before you deternine size of exported media/file. So, 
> IMHO it should be moved in separate function and called later.

Ah, that way. Right, misunderstood you then.

> >Hm. Do you mean that without this change, using nbd-server with -c
> >doesn't support different blocksizes?
> >
> Yes. functuin will return after reading first "page" of block. Other 
> pages are not readed :(.

Okay.

> I've test this patch ;)

Sure :-)

I just wanted to check before I'd apply, that's all. And it's been a
while since I had a look at 2.8, so I didn't recall all the details
anymore...

-- 
The amount of time between slipping on the peel and landing on the
pavement is precisely one bananosecond