Bug#1091743: apt-ftparchive: support No-Support-For-Architecture-all

[Tim Woodall <debianbugs@woodall.me.uk>]

Package: apt
Version: 2.6.1
Severity: wishlist

Dear Maintainer,

Please consider supporting No-Support-For-Architecture-all in
apt-ftparchive. This is a one line change to ftparchive/writer.cc

tim@dirac:~/git/apt (main)$ git diff
diff --git a/ftparchive/writer.cc b/ftparchive/writer.cc
index 3c5237915..5e917d188 100644
--- a/ftparchive/writer.cc
+++ b/ftparchive/writer.cc
@@ -1012,6 +1012,7 @@ ReleaseWriter::ReleaseWriter(FileFd * const GivenOutput, string const &/*DB*/) :
    Fields["Components"] = "";
    Fields["Description"] = "";
    Fields["Signed-By"] = "";
+   Fields["No-Support-for-Architecture-all"] = ""
    BoolFields["Acquire-By-Hash"] = _config->FindB("APT::FTPArchive::DoByHash", false);
    BoolFields["NotAutomatic"] = false;
    BoolFields["ButAutomaticUpgrades"] = false;


Testing:
$ cat bookworm-nodefault-aptftp.conf
APT::FTPArchive {
  DoByHash "true";
  Release {
    Origin "local debs";
    Label "local debs";
    Suite "stable-nodefault";
    Version "12";
    Codename "bookworm-nodefault";
    NotAutomatic "yes";
    ButAutomaticUpgrades "yes";
    Acquire-By-Hash "yes";
    Architectures "all amd64 i386 armel arm64";
    Components "main";
    Description "Debs for local installing";
    MD5 "yes";
    SHA1 "no";
    SHA256 "yes";
    SHA512 "no";
    No-Support-For-Architecture-all "Packages";
    ValidTime 31536000;
  };
};

Generates:
Acquire-By-Hash: yes
Architectures: all amd64 i386 armel arm64
ButAutomaticUpgrades: yes
Codename: bookworm-nodefault
Components: main
Date: Mon, 30 Dec 2024 19:13:32 +0000
Description: Debs for local installing
Label: local debs
No-Support-for-Architecture-all: Packages
NotAutomatic: yes
Origin: local debs
Suite: stable-nodefault
Valid-Until: Tue, 30 Dec 2025 19:13:32 +0000
Version: 12
MD5Sum:
 f893f7a4d6b717921e54661291504dd6              390 Release
 95b0f67449a6ee7ec41a015f2f125a8c           142291 main/Contents-all
 e122cf960be381c9a6b0b8f8290662f9             7500 main/Contents-all.gz
 489e3496a9aa84cd740b1cd82be44702           175676 main/Contents-amd64
 f7cf87c585ef7b902e3fdaec0eadbcc0            10927 main/Contents-amd64.gz
 f1ef067fe94e1f123e4c979c52a77567             4289 main/binary-all/Packages
 77db331ccd01c02539b908c8e9885d36             1924 main/binary-all/Packages.xz
 db2c3d4f91f44611adb243601d021030            20586 main/binary-amd64/Packages
 ed32ebb40f5251c2c7092e4762ba5182             6576 main/binary-amd64/Packages.xz
 b632d3e0adade02179345aea4f7e3789            11706 main/source/Sources
 521e5caa8320ed6844d8d00d8ffae230             3391 main/source/Sources.gz
 e1a778cb4abd07ee8850690fd7223c53             3204 main/source/Sources.xz
SHA256:
 3415dfd1da0adb29f7f989204a8af2547211773deee5b8841bc5156c90ed5bf4              390 Release
 435ba654dbacc62253a76bb0124d5a48b37931a5de9c9f1544994d257fcd1eba           142291 main/Contents-all
 e745280081045ece9458487cdb6ddda56a4a4748d9e6cce2c412a2ffc0b337f1             7500 main/Contents-all.gz
 b98e1b75f71819799d85a6856dd601cf78e5764e46798b1f0096be3c4d1bb78e           175676 main/Contents-amd64
 8afd6de519b810ea5fde26475f6480929d1836a242634e27f8aca623d7c7dea2            10927 main/Contents-amd64.gz
 e77d863f9b49ce32891de7187e4bc61ae85fd488a806220ad10f87889e70d131             4289 main/binary-all/Packages
 ee75247c30a462969739fd55f12c47b1d0c21bf5b4e0cd3cdb75f0fc6ede117c             1924 main/binary-all/Packages.xz
 9791f682646d6e379f1f079d38dd0e8d44f81de920c613aee209088248f51d74            20586 main/binary-amd64/Packages
 e49ff92a6eec1c263cd61c03095a1a1ffb4d38fc72aa46f1c4b2d93a1954108c             6576 main/binary-amd64/Packages.xz
 63caebd698d284035aa6bb797efd32b4ca0eb439f4cc169d6f22bf14bdb77cde            11706 main/source/Sources
 9568945331d5d611e8b34490fa4345aeccb224083f77526dde2b2b97b58d186b             3391 main/source/Sources.gz
 3e5c258063c02f951c9c3d5191d8698fc0b6edeca8f956efe08e17183535f0d6             3204 main/source/Sources.xz

Thanks.