Bug#733489: [PATCH] apt/package.py: Replaced pre_depend with rawtype in BaseDependency.__repr__ as rawtype gives more information including the information from pre_depend.
On Sun, Jun 28, 2015 at 01:49:17PM +0200, Michael Schaller wrote:
>
> On 06/28/2015 11:41 AM, Julian Andres Klode wrote:
> >Hi Michael,
> >
> >thanks for the patch. Unfortunately, I cannot apply it without
> >further work.
> >
> No worries. That was kinda expected after such a long break. ;-)
>
> >On Sat, Jun 27, 2015 at 12:39:49PM +0200, Michael Schaller wrote:
> >>---
> >> apt/package.py | 4 ++--
> >> debian/changelog | 6 ++++++
> >> 2 files changed, 8 insertions(+), 2 deletions(-)
> >
> >Could you please include the entire patch? I can't merge that with
> >git am otherwise. You somehow only put the diff into the patch file
> >attachment, and moved the subject into the emails subject and the
> >stat into the first part of the email.
> >
> I've just used standard 'git send-email --attach'. I've used now 'git
> format-patch' and attached the generated patch manually to this email. I
> hope that works better for you.
>
> >Also, please format your commit messages to have a short summary
> >(about 70 characters) followed by a longer paragraph.
> >
> 75 is as short as I can make it. I hope is sufficiently short.
I reworded it a bit:
- Dropped the filename to make the subject shorter
- Dropped the '.' at the end of the subject
- Changed from past to present tense
- Made one sentence out of the paragraph
and applied it to the debian/sid branch.
--
Julian Andres Klode - Debian Developer, Ubuntu Member
See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
Be friendly, do not top-post, and follow RFC 1855 "Netiquette".
- If you don't I might ignore you.
Reply to: