Bug#624379: python-apt: make required_changes and missing_deps automatically call check() when needed
Package: python-apt
Version: 0.8.0~exp4
Severity: wishlist
Tags: patch
I found it surprising that missing_deps and required_changes required
a call to check() first.
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: tshepang@gmail.com-20110427221153-fb7azvn3hkqyix2h
# target_branch: http://bzr.debian.org/apt/python-apt/debian-\
# experimental/
# testament_sha1: cac4924b099b4007a2eee52ca0a22ea887bd9107
# timestamp: 2011-04-28 00:14:14 +0200
# base_revision_id: jak@debian.org-20110427110820-qmhxr9c0rux0nn6r
#
# Begin patch
=== modified file 'apt/debfile.py'
--- apt/debfile.py 2011-04-06 09:15:47 +0000
+++ apt/debfile.py 2011-04-27 22:11:53 +0000
@@ -472,7 +472,7 @@
def missing_deps(self):
"""Return missing dependencies."""
self._dbg(1, "Installing: %s" % self._need_pkgs)
- if self._need_pkgs is None:
+ if not self._need_pkgs:
self.check()
return self._need_pkgs
@@ -485,6 +485,8 @@
install = []
remove = []
unauthenticated = []
+ if not self._cache:
+ self.check()
for pkg in self._cache:
if pkg.marked_install or pkg.marked_upgrade:
install.append(pkg.name)
=== modified file 'debian/changelog'
--- debian/changelog 2011-04-27 11:08:20 +0000
+++ debian/changelog 2011-04-27 22:11:53 +0000
@@ -2,6 +2,10 @@
* apt_pkg: Add OrderList, wanted for mancoosi (Closes: #623485)
+ [ Tshepang Lekhonkhobe ]
+ * apt/debfile.py: Remove the need to explcitly call check() in order
+ to get output from require_changes and missing_deps.
+
-- Julian Andres Klode <jak@debian.org> Wed, 27 Apr 2011 12:55:59 +0200
python-apt (0.8.0~exp3) experimental; urgency=low
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWVRWd48AAjLfgERQUXP//3IH
FYq////wUAUW8Voksbq63Wm7F28JJUyT2iGmJNgp6T1HqaDR6npAAGgBKTSZBoMjRE8kj1GjE9TI
AAyB6gkSJNT0nlNMj0mib0npRtGowA1DAAOYACZMACYTBMIYAjAAkkBARk01T8gTVP00yBNQ0eoN
MjR+pKAhLPYqZvu+2XwJ19H53Pr9b2pqQbcgmCpU6hW7MbCQKBVRadRiGNjZ4aw9J0lkbOXBfKcm
ihlk+/+lp8rof2cux9DgRPpDAgfPeMZkz+jMmcYn1GTxgkTI462246HrkW7vZPZI0L5rBZec2HVB
WiYGG4+IDsbdIUS2kzi+L719twKtGaHaSy0jbIh0kLJhmC+SzaQmxaExKWI0uEKnGqFkolhrIJmQ
qYyoGlwepJ6pZ4VQd2DoHtpSbldJAcVkcdHWxC1BECh9pk1+XGl2aX/EKzwDcfu5+IHlpYdk9oL1
4krC/fYXG0ZZdrolIWBuNjITyMawMrZgQ4aKlRveJUEIMYmeFKNgw9WmvgBaBQS0DWwJuHr7HCY+
m2PIDuNZe1xoe6kdUxVXAL4wBMNIo4IxwMYI41gNMzZoqZotqW7ETDR0BnPJbFFZTpACAzF/AtKM
cRyxgPaZdO15VvKsCdZnN26vRBiMakiuRYdiG0KNUilOyoGDFgHENLFbFleMh8q7mfOK0wCoqAgY
vMtkbWhIKSFUNMhxoLZk7GtzqJyHShbAzJDB8Xj7S6yVFFJeKahb14egqSixUjUoxg7Irm6Gitqc
AzA5qlGClz0iz9K3pWGFmON8gLtZ+zUtSP4gw2KyttNvxjaJgMucIZtFO6ruGLTN9KSq2OVY1ZFq
//E+959VJlHhyQ2idV9dAMV5u3HHu2UnkefgeftdaXl3VHNB90UL0Yka3gS7ytIqUCekvjrPZyUK
jW6+sBxdP2E+DwFhgaoSAgETTr5fED0Csao5eU1sPqqe7IUVzmY+FJ5D71OKFfoIVjF82ueiCkyb
5EF17ogfdAjKHOWDjTtZipFBST9PmS3yTNSZ3iokTlDLQxGnaueY6HI9I7qKmL57C8uRDZnEYlsc
fybPbbau3M0j30assVDZNuIx8im/DMuBMESpIwHjLZpp41HHcOKEeRNEIl21dPF6/E5BpcBxmhVL
oONGcxFzK2ODTkRCRmE1QcqDu9lSXo6MMluEyPHaOtZRikeoFJJjcFwnmZ36sEMta0LE7a9X1IaL
calUgsSHytSol0HpZS++io5kajaN7gcpHOlG6aL0dMjeZo8QKSRzAZoorRByKCCQ5RV97+9TyO9J
dUHFUmqs/gPfeZ02lFC2FMkh74FoQST6ioksCIMtEppDGoWhnQDUeQEewJqnHIPo41J6S5tOAiOs
Q75o0cQQvPdGhcIKZhI7LYnXpGxwwPUc9ZVjKg+CsNCIepsCR1AabBUFiPUILsnngsxoJaizm5SR
VFanq74D8JR7gZOHnfPwhUdrdbKs+5QgoL0QHh61QGUiR6BpgcIkU6kpUoN4X/Nab8grYcrIccCI
85suRGpRoPU8UxDhjCJqZPCir4wOG6Wk0kwMjMrEbAOvPIMAMjJnTPMGRwLLfQYcMcMAHZvpVDgO
RdyRThQkFRWd48A=
Reply to: