[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#280356: marked as done (apt-cdrom handles long lines in sources.list poorly)



Your message dated Tue, 06 Sep 2005 01:17:03 -0700
with message-id <E1ECYdb-0000Kg-00@spohr.debian.org>
and subject line Bug#280356: fixed in apt 0.6.41
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 8 Nov 2004 21:36:54 +0000
>From licquia@progeny.com Mon Nov 08 13:36:54 2004
Return-path: <licquia@progeny.com>
Received: from jeffindy.licquia.org [216.37.46.185] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CRHC2-0008Rr-00; Mon, 08 Nov 2004 13:36:54 -0800
Received: from sentinel.licquia.org (unknown [192.168.53.1])
	by jeffindy.licquia.org (Postfix) with ESMTP id 00F091BA9A
	for <submit@bugs.debian.org>; Mon,  8 Nov 2004 16:36:52 -0500 (EST)
Received: from server2.internal.licquia.org (server2.internal.licquia.org [192.168.50.4])
	by sentinel.licquia.org (Postfix) with ESMTP id BFAF2D51F
	for <submit@bugs.debian.org>; Mon,  8 Nov 2004 16:36:49 -0500 (EST)
Received: by server2.internal.licquia.org (Postfix, from userid 1000)
	id 670BB10A7C6; Mon,  8 Nov 2004 16:36:49 -0500 (EST)
Received: from [192.168.52.2] (laptop1.internal.licquia.org [192.168.52.2]) by
	server2.internal.licquia.org (tmda-ofmipd) with ESMTP;
	Mon, 08 Nov 2004 16:36:43 -0500 (EST)
Subject: apt-cdrom handles long lines in sources.list poorly
To: submit@bugs.debian.org
Content-Type: text/plain
Message-Id: <1099949801.4441.52.camel@laptop1>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Mon, 08 Nov 2004 16:36:42 -0500
Content-Transfer-Encoding: 7bit
From: Jeff Licquia <licquia@progeny.com>
X-Delivery-Agent: TMDA/1.0.3 (Seattle Slew)
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: apt
Version: 0.5.27

When apt-cdrom rewrites sources.list to add a CD reference, it uses a
300-byte buffer to read lines from the old sources.list.  For some
reason, if a line in sources.list is longer than 300 characters, the
ifstream object used for reading gets confused.  Subsequent reads result
in zero bytes being read.  Since we haven't reached EOF (there's still
the rest of that line, at least, to read), and since we have lost the
ability to read more data from the ifstream, the loop is infinite.

Moreover, newlines are stripped from the input sources.list, meaning
that they have to be replaced on output.  Since we're reading zero bytes
every time, we're writing a zero-byte string on every loop iteration
followed by a newline.  This will continue until the disk on which
sources.list exists is full.

I'm not sure if the bug is in apt or in libstdc++, since it is an
ifstream that's acting badly, but since the behavior is easily
duplicated in apt, that's where I'm filing.

[Sorry, Matt, for getting to this late; things have been busy at Progeny
the past week...]


---------------------------------------
Received: (at 280356-close) by bugs.debian.org; 6 Sep 2005 08:19:54 +0000
>From katie@spohr.debian.org Tue Sep 06 01:19:54 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1ECYdb-0000Kg-00; Tue, 06 Sep 2005 01:17:03 -0700
From: Michael Vogt <mvo@debian.org>
To: 280356-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#280356: fixed in apt 0.6.41
Message-Id: <E1ECYdb-0000Kg-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Tue, 06 Sep 2005 01:17:03 -0700
Delivered-To: 280356-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2

Source: apt
Source-Version: 0.6.41

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive:

apt-doc_0.6.41_all.deb
  to pool/main/a/apt/apt-doc_0.6.41_all.deb
apt-utils_0.6.41_i386.deb
  to pool/main/a/apt/apt-utils_0.6.41_i386.deb
apt_0.6.41.dsc
  to pool/main/a/apt/apt_0.6.41.dsc
apt_0.6.41.tar.gz
  to pool/main/a/apt/apt_0.6.41.tar.gz
apt_0.6.41_i386.deb
  to pool/main/a/apt/apt_0.6.41_i386.deb
libapt-pkg-dev_0.6.41_i386.deb
  to pool/main/a/apt/libapt-pkg-dev_0.6.41_i386.deb
libapt-pkg-doc_0.6.41_all.deb
  to pool/main/a/apt/libapt-pkg-doc_0.6.41_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 280356@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Vogt <mvo@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon,  5 Sep 2005 22:59:03 +0200
Source: apt
Binary: apt-utils libapt-pkg-doc libapt-pkg-dev apt-doc apt
Architecture: source all i386
Version: 0.6.41
Distribution: unstable
Urgency: low
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Michael Vogt <mvo@debian.org>
Description: 
 apt        - Advanced front-end for dpkg
 apt-doc    - Documentation for APT
 apt-utils  - APT utility programs
 libapt-pkg-dev - Development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - Documentation for APT development
Closes: 225947 280356 282918 316314 319142 321799 322120 322267 322483
Changes: 
 apt (0.6.41) unstable; urgency=low
 .
   * improved the support for "error" and "conffile" reporting from
     dpkg, added the format to README.progress-reporting
   * added README.progress-reporting to the apt-doc package
   * improved the network timeout handling, if a index file from a
     sources.list times out or EAI_AGAIN is returned from getaddrinfo,
     don't try to get the other files from that entry
   * Support architecture-specific extra overrides
     (closes: #225947). Thanks to  Anthony Towns for idea and
     the patch, thanks to Colin Watson for testing it.
   * Javier Fernandez-Sanguino Pen~a:
     - Added a first version of an apt-secure.8 manpage, and modified
       apt-key and apt.end accordingly. Also added the 'update'
       argument to apt-key which was previously not documented
       (Closes: #322120)
   * Andreas Pakulat:
     - added example apt-ftparchive.conf file to doc/examples
       (closes: #322483)
   * Fix a incorrect example in the man-page (closes: #282918)
   * Fix a bug for very long lines in the apt-cdrom code (closes: #280356)
   * Fix a manual page bug (closes: #316314)
   * Do md5sum checking for file and cdrom method (closes: #319142)
   * Change pkgPolicy::Pin from private to protected to let subclasses
     access it too (closes: #321799)
   * add default constructor for PrvIterator (closes: #322267)
   * Reread status configuration on debSystem::Initialize()
     (needed for apt-proxy, thanks to Otavio for this patch)
Files: 
 090ba076d2cb8ff0f5bd3268fc6db98b 785 admin important apt_0.6.41.dsc
 e2b3b7efa18819697b98bc331be5d753 1404829 admin important apt_0.6.41.tar.gz
 fc382e26c7799f24ee016d63a91e5444 84582 doc optional apt-doc_0.6.41_all.deb
 b7489b71812e7f04a539c0f70eedfbab 107782 doc optional libapt-pkg-doc_0.6.41_all.deb
 b7c2bd26e1a5ec6f1136647f9b6cfeaa 1234008 base important apt_0.6.41_i386.deb
 5587979998d3b3dce41d7a83ab037029 78202 libdevel optional libapt-pkg-dev_0.6.41_i386.deb
 907fa6bba6bd83fbad68d05f6af97af6 202964 admin important apt-utils_0.6.41_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDHLu0liSD4VZixzQRApG0AJ9pQEbQ8+0OZFPIcS84DekOX3597QCeJir6
D9MF0Ztx9yF6zZxjbTItpeA=
=NX47
-----END PGP SIGNATURE-----



Reply to: