[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Minor suggestions on WML source files



Hi,

here are some files you may fix to avoid future problems with WML:

* template/debian/recent_list.wml
* SPI/template/recent_list.wml
* template/debian/event.wml 
* template/debian/past_event.wml 
* template/debian/weeklynews/index.wml 
* events/index.wml
  They contain things like
      if ($line =~ /^<define-tag pagetitle>(.*)<\/define-tag>$/)
  If you write
      if ($line =~ m|^<define-tag pagetitle>(.*)</define-tag>$|)
  then this line will redefine <pagetitle> which is obviously wrong.
  For safety reasons, you should write

    <protect pass=2>
... your code here...
    </protect>

  Note that current behaviour is buggy, WML should report an error
  because the ``define-tag'' tag does not have an endtag.

* distrib/vendors.CD
  Right bracket is missing at end of line in lines
   122 931 943

Regards

-- 
Denis Barbier
WML Maintainer


Reply to: