[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1111590: Bug#1110852: ITP: phoenix-esr -- A Firefox-ESR config designed to put the user first.



Hi  josch.


>  Do both firefox and firefox-esr use /etc/firefox? 

Yes,
Those just  are not the same in the /usr/lib

>  When building the package I found an issue with debian/watch. You can fix it
>  with this patch:
>  
>  --- a/debian/watch
>  +++ b/debian/watch
>  @@ -1,3 +1,3 @@
>   version=4
>  -opts="dversionmangle=s/\+dfsg\d*$//,repacksuffix=+dfsg"
>  +opts="dversionmangle=s/\+dfsg\d*$//,repacksuffix=+dfsg" \
>    https://codeberg.org/celenity/phoenix/tags .*/@ANY_VERSION@@ARCHIVE_EXT@
>  
>  The "opts" line was missing a trailing backslash.

Ok, I'll fix these 4 days later.
I'm now in Tehran for university exams.


>  Also please fix the COPYING file to be identical to the one in the upstream
>  version.

Ok.

>  Lastly, while you are at it, could you please adjust the package description to
>  be a bit more aesthetically pleasing?
>
>   * the short description should not end in three dots
>   * there is an empty line in the middle of a sentence above "designed to put"
>   * there is a spelling error: "featuers"
>   * I think it's Firefox and not FireFox, no?
>   * you can spell out "configs" as "configurations"
>   * the package description format supports lists where each list item is
>     prefixed with a "*" similar to the list you are currently reading. You can
>     use this formatting feature for the list of "Some elementary features"

Ok


Thank you very much!


Reply to: