[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1012720: RFS: golang-github-google-gnostic-models/0.6.8-1 [ITP] -- Protocol buffer models for gnostic



On Wed, Dec 20, 2023 at 08:35:38AM +0100, Nicolas Schier wrote:
> Hi,
> 
> I've packaged golang-github-google-gnostic-models, and I need a sponsor
> to get it uploaded.  The package is a requirement for golang-k8s-apimachinery
> (cp. #1012720).

Few comments:

* You do not need a separate hand-crafted .install files to install extra things you need.
  Please use DH_GOLANG_INSTALL_EXTRA in d/rules for that.
* The d/copyright should probably mention "Google LLC" instead of "Google Inc." since that's
  what is mentioned in all the source code files.
* Standards version can be updated to 4.6.2
* README.md as docs can be dropped. In principle no-one would install a lib package and read the
  README. The lib packages in golang are mainly needed for target consumable binary packages.

LMK once you address them!

Best,
Nilesh

Attachment: signature.asc
Description: PGP signature


Reply to: