[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal



Hi Maytham,

On Fri, Nov 10, 2023 at 05:15:22PM +0800, Maytham Alsudany wrote:
> On Thu, 2023-11-09 at 00:32 +0530, Nilesh Patra wrote:
> > * Can you please clean up some of the lintian stuff? And then we could
> >   upload the new release.
> 
> Letting you know that I've fixed the majority of lintian's errors/warnings, and
> the latest report now looks like this[1].

Awesome, thank you!

> If would be good to get a second pair of eyes on my commits, since I've made
> some decisive patches.

I have removed all commits adding manpage. Furthermore you added a
compress command to dh_auto_test this would lead to installing different
manpage based on whether or not tests are run (for instance skipped via
nocheck). This is a bug, IMHO.

My personal experience is that maintainer maintained manpages are
seldom well-maintained and tend to get outdated with new versions
if the maintainer forgets to update these regularly.
Also, that manpages keep introducing new lintian warnings with new
version of troff/groff.

Since this package already requires some maintenance, I feel it would be
an additional burden on me and you. It is IMHO the best case scenario if
the upstream maintains a manpage themselves.

You may wonder that it might be possible to add a help2man directive in
d/rules to fix this problem, but then this gets the package to not be
able to cross-build and the problem with troff still remains. Go
binaries do not natively cross-build via debian way of cross-compilation
via hostarch yet but I suppose it would one day.

> If all's good, then I reckon that the new release is ready to be uploaded.

Pushed to experimental; thank you for your work! \o/

> You probably already know, but upstream released version 0.31.0 a few days ago,
> which makes the version we're working on (0.30.1) outdated. I think we should do
> a version bump after we upload 0.30.1 so we have a working package uploaded,
> even if it's one version old. The version bump can also act as a stability
> check, to see if the package still builds successfully when the version gets
> bumped.

Agreed, and thanks again! :D

Best,
Nilesh

Attachment: signature.asc
Description: PGP signature


Reply to: