[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1054270: ITP: python-schwifty -- work with IBANs and BICs



Am 23.10.23 um 12:50 schrieb Matthias Geiger:
On Sat, 21 Oct 2023 20:21:41 +0200 Bastian Germann <bage@debian.org> wrote:
 > Hi Matthias,
 >
 > On Fri, 20 Oct 2023 12:27:06 +0200 Matthias Geiger wrote:
 > > This is the last library needed for banking. The packaging for it is
 > > done; it'll be maintained with the debian python team.
 >
 > Can you please make the package available at
 > https://salsa.debian.org/python-team/packages/python-schwifty
 > but with the Python Team's git layout.
 > werdahias/schwifty does not apply separating upstream from debian changes.
 >
 > Thanks,
 > Bastian
 >

done. I still got two minor issues I haven't been able to solve: To build the documentation a patch changing the version number is needed. I tried using DEB_UPSTREAM_VERSION from the enviroment

but wasn't successful; so I hardcoded it for now. What would be the proper way to do so, i.e. using DEB_UPSTREAM_VERSION ?

See my commit after yours.

The second issue is that I wanted to remove the *.json data after installing so that doesn't end up in the binary package but execute_after_dh_auto_install: and a subsequent rm didn't do the trick.

Any idea why this isn't working here ?

Because you used the path where dh_python3 moves the files. That program kicks in after dh_auto_install. In general, it is a good idea to use find debian/python3-schwifty -name ... -delete for such an endeavour. But I have fixed it with an env variable that I have introduced for the first question.


Reply to: