Bug#694077: Package review

[Jérôme Lebleu <jerome@maroufle.fr>]

Hi Lisandro,

Le 25/08/2019 à 17:33, Lisandro Damián Nicanor Pérez Meyer a écrit :
> On Sun, 25 Aug 2019 at 12:26, Lisandro Damián Nicanor Pérez Meyer
> <perezmeyer@gmail.com> wrote:
> [snip]
>>
>> Mmm, I'm not entirely sure if the code in plugins/hid is
>> DFSG-compliant. It's license it's too lax. I think I'll upload it non
>> the less in the meantime, and see what FTP masters think.
> 
> Better yet, I looked for previous art within Debian and found:
> 
> <http://codesearch.debian.net/search?q=HIDAPI_H__&literal=1>
> 
> And more specifiically:
> 
> <http://codesearch.debian.net/show?file=libsdl2_2.0.9%2Bdfsg1-1%2Fsrc%2Fhidapi%2Fhidapi%2Fhidapi.h&line=27>
> 
> As you can see the license is much clearer there. This is something
> that must be solved before uploading. Ideally by fixing it upstream,
> but a patch might do the work in the meantime.

Thanks a lot for your report and your research. I have submitted a patch
that Massimo has already merged! He also just published a new release
which includes it - and other patches. It is just the perfect timing!

Moreover, he also opened an issue to discuss about the Debian packaging
and tell some things to change for cross-compiling here:

  https://github.com/mcallegari/qlcplus/issues/1191.

Also, the ola plugin is currently not integrated but I plan to have a
look after this first release. Is it okay for you?

I have successfully build the package for 4.12.2 and so released and
pushed it. I let you have a look and upload it if everything looks fine!

Cheers,

Jérôme