Am Donnerstag, den 11.04.2019, 21:34 +0200 schrieb Stefan Potyra: > Hi Bruno, > > > On Mon, Apr 08, 2019 at 08:14:02PM +0200, Bruno Kleinert wrote: > > Hi Stefan, > > > > I only had minor improvements, see attached debdiff. Those include: > > * Set debhelper compatibility level by build dependency magic. > > * Update the .desktop file patch to remove a broken line and add > > another category for the tool. > > * Override lintian warning for source tarball repack and provide a > > rationale. > > Looks good in the debdiff! > > > I *think* the "Copyright (c)" part is redundant in debian/copyright > > and > > could possibly be removed from lines 27-32. > > < > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#copyright-field > > > > Actually, the examples all have "Copyright" there. > > Debdiff looks fine to me, thanks for the review including the > proposed changes. > > How to proceed? > Do you want to upload the package with your debdiff applied? > Or should I apply it and propose a new .dsc file? > > Cheers, > Stefan. Hi Stefan, I'd prefer you to apply the changes and provide an updated source package. Then I will happily sponsor the upload to NEW :) Cheers - Bruno
Attachment:
signature.asc
Description: This is a digitally signed message part