Hi Tobi, On Fr 07 Dez 2018 08:16:35 CET, Tobias Junghans wrote:
Hi Mike,Uploaded 20min ago.Perfect, thanks a lot! A few questions and suggestions for future uploads though: * switch project website (https://veyon.io) to https in Homepage field
done
* use lower-case for github group for Source field
done (some other places within debian/ subfolder)
* update to 4.1.5
I would like to skip 4.1.5. See below.
* replace "iTALC" with "Veyon" in copyright
found + fixed
* why is kde-baseapps-bin recommended? Veyon is not KDE-related at all
In Debian, we had a wrapper script around the ica client executable that did some error handling if users were not in the correct group(s).
As veyon-service is now a systemd system service, the wrapper script has been dropped. And so should the Recommends: field.
-> done.
* as of upcoming 4.1.6 release you should reconsider to not repack the source tarball as all unused source files (except for x11vnc/libvncserver) will get stripped anyway (https://github.com/veyon/veyon/commit/ cc54151fb31524bd67a6160acaac1204f55e9ccd).
That is great news!!! When is the due date of 4.1.6. Will you make it for Debian buster's soft freeze (midst of February)?
https://wiki.debian.org/DebianBuster Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Attachment:
pgpNSZJfbiUml.pgp
Description: Digitale PGP-Signatur