Bug#881459: ITP: obsidian-icon-theme -- Obsidian icon theme
Control: retitle -1 ITP: obsidian-icon-theme -- Obsidian icon theme
Control: owner -1 Omar Jair Purata Funes <omarpurataf@gmail.com>
Hi,
I am interested in sponsoring this package for you. If you need a
sponsor, I encourage you to file a RFS bug (Request for Sponsor) next
time. I believe this is encouraged at https://mentors.debian.net That
way, people interested in sponsoring packages will have a better
chance of seeing your work.
By the way, I am interested in starting a theme packaging team next
year. I'll let you know when that team is created in case you are
interested then.
Here are some issues I noticed while reviewing the package. Please fix them.
debian/changelog
=============
1. For a new package to Debian, there should be only one
debian/changelog entry, the Initial release line.
2. The correct bug title for a package you are packaging is ITP
(Intent to Package) not RFP (Request for Package, in other words, a
request for someone else to package it). I have corrected that for
you.
debian/control
===========
3. I think a majority of -icon-theme packages use Section: x11. Since
it can be used outside GNOME and isn't a GNOME project, I think x11 is
a better place for it.
4. The Vcs fields are intended for the debian/ packaging not the
upstream repository.
5. Please add a space after Homepage:
6. ${shlibs:Depends} is only needed for library packages so please remove it.
debian/rules
==========
7. Please drop the override_dh_builddeb rule. The default is already
xz with adequate compression.
8. The override_dh_install rule looks unnecessary to me since the
files appear to already have the correct permissions.
other
===
9. Please drop debian/dirs. It's not needed here
10. Please use debhelper compat 10 (update debian/compat and debian/control)
copyright
=======
The copyright and license status is arguably the most important thing
that ftpmasters look at when deciding whether to accept or reject a
new package into Debian.
11. Please ask upstream if this is really all original work. If it is
derived from another theme, then the copyright holders for the derived
parts need to be specified.
12. My understanding of the GPL3 license is that the license text
itself should be distributed with the source code. Please ask upstream
to do this for their next release.
Feel free to reply if you have questions.
Thanks,
Jeremy Bicha
Reply to: