[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#857248: nullmailer: bug found!



Hi David,

To save you and others time I filed pull requests for the 'errno' bug and the fix for race conditions. Hope this did not preempt your review. Thank you for looking at my patches!

Best regards,
Felix


On Tue, Sep 5, 2017 at 3:52 AM, David Bremner <david@tethera.net> wrote:
Felix Lechner <felix.lechner@lease-up.com> writes:

> David,
>
> I found the bug affecting the tests. (It was an issue only when TLS was
> enabled, and there were some race conditions.) I packaged version 2.0
> and uploaded
> it to Mentors <https://mentors.debian.net/package/nullmailer>.
>
> You are still welcome to adopt the package. Or, you can sponsor me---I
> really don't care. Just trying to help.

OK, I'm (slowly) looking at your patches. My current plan is to
integrate (most of) your changes and add you as an Uploader to the
package in collab-maint. That's mostly symbolic but it might help get a
sponsor in the future if I'm not available.

> Some of the open items in my version are:
>
> 1. Syslog code (and therefore '--daemon') not adopted from prior version.
> It probably would be a good idea, but is complicated, and the package works
> without it.

I think this is probably gone for good. We do have to take a bit more
care: I think /etc/init.d/nullmailer probably needs to be dropped from
the package, since it relies on -s. A NEWS item for those people relying
on non-systemd inits seems also needed.

>
> 2. I slightly modified the interplay between '/etc/mailname', 'me' and
> 'defaulthost' to allow the tests to complete. Not sure if that broke the
> '/etc/mailname' behavior. I don't use that feature.
>

Was there more than just grouping patches here?


Reply to: