[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#743638: RFP: shairport -- Play music streamed from iTunes/iPads/iPods



On 2015-12-21 00:48, Daniel Carter wrote:
> On Sun, 20 Dec 2015 09:47:23 +0000 Chris Boot <debian@bootc.net
> <mailto:debian@bootc.net>> wrote:
>>
>> I would *definitely* appreciate patches from anyone who wishes to help,
>> or even co-maintenance.
> 
> Nice work.  
> 
> I just put a bit of effort into getting the systemd service side of
> things working.  Happy to contribute those, see attached diff. (not sure
> how alioth works, cant see how to do a pull request there?).  The patch
> for the systemd unit path i have done a pull request for, so if that is
> accepted you can drop that.
> 
> Though perhaps you intend this not to be a daemon package?

Hi Dan,

Thanks for the patch! I think I'm going to go down a different route for
the init script and systemd units. I'd like to modify them both to use a
defaults file in order to specify additional arguments and I don't think
it's appropriate to include all the various command-line examples in the
init script. After all, Debian doesn't expect users to touch init
scripts at all.

I definitely intend for the package to run a daemon, though.

I've added the postinst script already based on what you supplied though:

http://anonscm.debian.org/cgit/collab-maint/shairport-sync.git/commit/?id=9cf3a18293f687d18e4a72c6abda9e3480143644

Thanks again!

Cheers,
Chris

-- 
Chris Boot
debian@bootc.net
GPG: 8467 53CB 1921 3142 C56D  C918 F5C8 3C05 D9CE EEEE


Reply to: