[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#715426: Bug # 715426: Interested in getting this done



On 30 November 2015 at 19:54, Tianon Gravi <admwiggin@gmail.com> wrote:
> I use lintian from sid, not from a release, since that's the only way
> I know of to make sure I've got the latest updates.  In this case, I
> run ran "lintian refind_*.changes", not even the usual
> "-EvIL+pedantic" I usually like perusing (but which normally has quite
> a few more false positives).

Ok, got a fresh run now that debian/copyright doesn't have
syntactically-invalid syntax and now that I'm testing against the
latest upstream snapshot (dca8799), and things got a lot more
colorful:

E: refind source: source-is-missing icons/licenses/Creative Commons
Legal Code_files/errata.js
E: refind source: source-is-missing
themes/snowy/snowy/licenses/Creative Commons Legal
Code_files/errata.js
W: refind source: dep5-copyright-license-name-not-unique (paragraph at line 244)
W: refind source: dep5-copyright-license-name-not-unique (paragraph at line 244)
W: refind source: dep5-copyright-license-name-not-unique (paragraph at line 257)
W: refind source: dep5-copyright-license-name-not-unique (paragraph at line 257)
W: refind source: file-without-copyright-information BUILDING.txt
W: refind source: file-without-copyright-information COPYING.txt
W: refind source: file-without-copyright-information CREDITS.txt
W: refind source: file-without-copyright-information LICENSE.txt
W: refind source: file-without-copyright-information Make.common
W: refind source: file-without-copyright-information Make.tiano
W: refind source: file-without-copyright-information Makefile
W: refind source: file-without-copyright-information NEWS.txt
W: refind source: file-without-copyright-information README.txt
W: refind source: file-without-copyright-information debian/changelog
W: refind source: file-without-copyright-information debian/compat
W: refind source: file-without-copyright-information debian/control
W: refind source: file-without-copyright-information debian/copyright
W: refind source: file-without-copyright-information debian/gbp.conf
W: refind source: file-without-copyright-information debian/refind.doc-base
W: refind source: file-without-copyright-information debian/refind.docs
W: refind source: file-without-copyright-information debian/refind.install
W: refind source: file-without-copyright-information debian/refind.links
W: refind source: file-without-copyright-information debian/refind.manpages
W: refind source: file-without-copyright-information debian/rules
W: refind source: file-without-copyright-information debian/source/format
W: refind source: file-without-copyright-information debian/watch
W: refind source: file-without-copyright-information filesystems/AutoGen.c
W: refind source: file-without-copyright-information filesystems/AutoGen.h
W: refind source: file-without-copyright-information filesystems/Doxyfile
W: refind source: file-without-copyright-information filesystems/LICENSE.txt
W: refind source: file-without-copyright-information filesystems/LICENSE_GPL.txt
W: refind source: file-without-copyright-information filesystems/design.dox
W: refind source: file-without-copyright-information
filesystems/edk2/ComponentName.h
W: refind source: file-without-copyright-information
filesystems/edk2/DriverBinding.h
W: refind source: file-without-copyright-information filesystems/fsw_base.h
W: refind source: file-without-copyright-information filesystems/fsw_core.c
W: refind source: file-without-copyright-information filesystems/fsw_core.h
W: refind source: file-without-copyright-information filesystems/fsw_efi.c
W: refind source: file-without-copyright-information filesystems/fsw_efi.h
W: refind source: file-without-copyright-information filesystems/fsw_ext2.c
W: refind source: file-without-copyright-information filesystems/fsw_ext2.h
W: refind source: file-without-copyright-information filesystems/fsw_hfs.c
W: refind source: file-without-copyright-information filesystems/fsw_hfs.h
W: refind source: file-without-copyright-information filesystems/fsw_iso9660.c
W: refind source: file-without-copyright-information filesystems/fsw_iso9660.h
W: refind source: file-without-copyright-information filesystems/fsw_reiserfs.c
W: refind source: file-without-copyright-information filesystems/fsw_reiserfs.h
W: refind source: file-without-copyright-information filesystems/fsw_strfunc.h
W: refind source: file-without-copyright-information filesystems/hfs_format.h
W: refind source: file-without-copyright-information filesystems/lzoconf.h
W: refind source: file-without-copyright-information filesystems/lzodefs.h
W: refind source: file-without-copyright-information filesystems/minilzo.c
W: refind source: file-without-copyright-information filesystems/minilzo.h
W: refind source: file-without-copyright-information filesystems/test/README
W: refind source: file-without-copyright-information
filesystems/test/fsw_posix.c
W: refind source: file-without-copyright-information
filesystems/test/fsw_posix.h
W: refind source: file-without-copyright-information
filesystems/test/fsw_posix_base.h
W: refind source: file-without-copyright-information filesystems/test/lslr.c
W: refind source: file-without-copyright-information filesystems/test/lsroot.c
W: refind source: file-without-copyright-information fonts/README.txt
W: refind source: file-without-copyright-information icons/README
W: refind source: file-without-copyright-information
icons/licenses/Creative Commons Legal Code.html
W: refind source: file-without-copyright-information
icons/licenses/Creative Commons Legal Code_files/cc-logo.jpg
W: refind source: file-without-copyright-information
icons/licenses/Creative Commons Legal Code_files/deed3-print.css
W: refind source: file-without-copyright-information
icons/licenses/Creative Commons Legal Code_files/deed3.css
W: refind source: file-without-copyright-information
icons/licenses/Creative Commons Legal Code_files/errata.js
W: refind source: file-without-copyright-information
icons/licenses/Creative Commons Legal Code_files/unported.png
W: refind source: file-without-copyright-information icons/licenses/gpl-2.0.txt
W: refind source: file-without-copyright-information icons/licenses/lgpl-3.0.txt
W: refind source: file-without-copyright-information icons/tool_part.png
W: refind source: file-without-copyright-information images/back-normal-big.png
W: refind source: file-without-copyright-information
images/back-normal-small.png
W: refind source: file-without-copyright-information
images/back-selected-big.png
W: refind source: file-without-copyright-information
images/back-selected-small.png
W: refind source: file-without-copyright-information images/font.png
W: refind source: file-without-copyright-information images/imgprepare.py
W: refind source: file-without-copyright-information images/linux-bootlogo.png
W: refind source: file-without-copyright-information images/mkeei.py
W: refind source: file-without-copyright-information images/mkegemb.py
W: refind source: file-without-copyright-information images/refind_banner.bmp
W: refind source: file-without-copyright-information images/refind_banner.odt
W: refind source: file-without-copyright-information images/txt.pl
W: refind source: file-without-copyright-information images/windows-bootlogo.png
W: refind source: file-without-copyright-information keys/README.txt
W: refind source: file-without-copyright-information
keys/SLES-UEFI-CA-Certificate.cer
W: refind source: file-without-copyright-information
keys/SLES-UEFI-CA-Certificate.crt
W: refind source: file-without-copyright-information keys/altlinux.cer
W: refind source: file-without-copyright-information keys/canonical-uefi-ca.crt
W: refind source: file-without-copyright-information keys/canonical-uefi-ca.der
W: refind source: file-without-copyright-information keys/fedora-ca.cer
W: refind source: file-without-copyright-information keys/fedora-ca.crt
W: refind source: file-without-copyright-information
keys/microsoft-kekca-public.der
W: refind source: file-without-copyright-information
keys/microsoft-pca-public.der
W: refind source: file-without-copyright-information
keys/microsoft-uefica-public.der
W: refind source: file-without-copyright-information
keys/openSUSE-UEFI-CA-Certificate.cer
W: refind source: file-without-copyright-information
keys/openSUSE-UEFI-CA-Certificate.crt
W: refind source: file-without-copyright-information keys/refind.cer
W: refind source: file-without-copyright-information keys/refind.crt
W: refind source: file-without-copyright-information mkcdimage
W: refind source: file-without-copyright-information mkdistrib
W: refind source: file-without-copyright-information old-banners/refind.svg
W: refind source: file-without-copyright-information old-banners/refind_blue.png
W: refind source: file-without-copyright-information
old-banners/refind_lighter.png
W: refind source: file-without-copyright-information
old-banners/refind_metal.png
W: refind source: file-without-copyright-information
old-banners/refind_original.png
W: refind source: file-without-copyright-information refind-alt.spec
W: refind source: file-without-copyright-information refind.conf-sample
W: refind source: file-without-copyright-information refind.inf
W: refind source: file-without-copyright-information refind.spec
W: refind source: file-without-copyright-information themes/snowy/README.txt
W: refind source: file-without-copyright-information themes/snowy/snowy/README
W: refind source: file-without-copyright-information
themes/snowy/snowy/arrow_left.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/arrow_right.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/banner-snowy.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/boot_linux.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/boot_win.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/func_about.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/func_csr_rotate.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/func_exit.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/func_firmware.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/func_reset.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/func_shutdown.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/licenses/Creative Commons Legal Code.html
W: refind source: file-without-copyright-information
themes/snowy/snowy/licenses/Creative Commons Legal
Code_files/cc-logo.jpg
W: refind source: file-without-copyright-information
themes/snowy/snowy/licenses/Creative Commons Legal
Code_files/deed3-print.css
W: refind source: file-without-copyright-information
themes/snowy/snowy/licenses/Creative Commons Legal
Code_files/deed3.css
W: refind source: file-without-copyright-information
themes/snowy/snowy/licenses/Creative Commons Legal
Code_files/errata.js
W: refind source: file-without-copyright-information
themes/snowy/snowy/licenses/Creative Commons Legal
Code_files/unported.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/licenses/lgpl-3.0.txt
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_arch.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_centos.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_chakra.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_chrome.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_clover.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_crunchbang.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_debian.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_elementary.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_fedora.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_freebsd.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_frugalware.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_gentoo.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_gummiboot.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_haiku.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_hwtest.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_kubuntu.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_legacy.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_linux.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_linuxmint.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_lubuntu.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_mac.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_mageia.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_mandriva.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_netbsd.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_network.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_opensuse.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_redhat.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_refind.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_refit.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_slackware.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_suse.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_ubuntu.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_unknown.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_win.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_win8.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/os_xubuntu.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/arrow_left.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/arrow_right.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/boot_win.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/func_csr_rotate.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_clover.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_debian.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_elementary.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_gummiboot.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_haiku.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_legacy.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_mac.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_netbsd.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_redhat.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_refind.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_refit.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/os_win.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/tool_apple_rescue.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/tool_memtest.svg
W: refind source: file-without-copyright-information
themes/snowy/snowy/svg/tool_rescue.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_apple_rescue.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_memtest.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_mok_tool.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_netboot.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_part.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_rescue.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_shell.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/tool_windows_rescue.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/transparent.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/vol_external.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/vol_internal.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/vol_net.png
W: refind source: file-without-copyright-information
themes/snowy/snowy/vol_optical.png
W: refind source: missing-license-paragraph-in-dep5-copyright see
comments in file (paragraph at line 94)
W: refind source: missing-license-paragraph-in-dep5-copyright lgpl-2.1
(paragraph at line 77)
W: refind source: missing-license-paragraph-in-dep5-copyright
lgpl-2.1+ (paragraph at line 58)
W: refind source: missing-license-paragraph-in-dep5-copyright creative
commons attribution-share alike 3.0 cc-sa 3.0) (paragraph at line 266)
W: refind source: missing-license-paragraph-in-dep5-copyright fdl 1.3
(paragraph at line 290)
W: refind source: missing-license-paragraph-in-dep5-copyright
bsd-2-clause (paragraph at line 102)
W: refind source: missing-license-paragraph-in-dep5-copyright gpl-2
(paragraph at line 280)
W: refind source: missing-license-paragraph-in-dep5-copyright ufl-1
ubuntu font license) (paragraph at line 285)
W: refind source: missing-license-paragraph-in-dep5-copyright sil-1.10
(paragraph at line 270)
W: refind source: missing-license-paragraph-in-dep5-copyright lgplv3+
(paragraph at line 266)
W: refind source: missing-license-paragraph-in-dep5-copyright gplv2
(paragraph at line 262)
W: refind source: missing-license-paragraph-in-dep5-copyright
cc-sa-3.0 (paragraph at line 253)
W: refind source: missing-license-paragraph-in-dep5-copyright gpl-3+
(paragraph at line 276)
W: refind source: missing-license-paragraph-in-dep5-copyright zlib
(paragraph at line 73)
W: refind source: missing-license-paragraph-in-dep5-copyright expat
(paragraph at line 90)
W: refind source: missing-license-paragraph-in-dep5-copyright lgpl-3+
(paragraph at line 253)
W: refind source: missing-license-paragraph-in-dep5-copyright ????
(paragraph at line 67)
W: refind source: missing-license-paragraph-in-dep5-copyright
bsd-3-clause (paragraph at line 167)
W: refind source: missing-license-paragraph-in-dep5-copyright gpl-2+
(paragraph at line 172)
W: refind source: invalid-short-name-in-dep5-copyright lgplv3+
(paragraph at line 266)
W: refind source: space-in-std-shortname-in-dep5-copyright ufl-1
ubuntu font license) (paragraph at line 285)
W: refind source: invalid-short-name-in-dep5-copyright gplv2
(paragraph at line 262)
W: refind source: space-in-std-shortname-in-dep5-copyright creative
commons attribution-share alike 3.0 (paragraph at line 257)
W: refind source: space-in-std-shortname-in-dep5-copyright tables
extracted from it, as (paragraph at line 49)
W: refind source: space-in-std-shortname-in-dep5-copyright "you may
use this program (paragraph at line 49)
W: refind source: space-in-std-shortname-in-dep5-copyright see
comments in file (paragraph at line 94)
W: refind source: space-in-std-shortname-in-dep5-copyright creative
commons attribution-share alike 3.0 cc-sa 3.0) (paragraph at line 266)
W: refind source: space-in-std-shortname-in-dep5-copyright fdl 1.3
(paragraph at line 290)
E: refind: copyright-should-refer-to-common-license-file-for-lgpl
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/bootmode.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/configfile.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/drivers.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/features.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/getting.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/index.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/installing.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/linux.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/revisions.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/secureboot.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/sip.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/themes.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/todo.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/using.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)
E: refind: privacy-breach-donation
usr/share/doc/refind/refind/yosemite.html
(https://www.paypalobjects.com/en_us/i/btn/btn_donate_lg.gif)

To fix "dep5-copyright-license-name-not-unique" and
"missing-license-paragraph-in-dep5-copyright" we need to add proper
"License" sections with license text and reference them by short name
in the preceding blocks.  For "file-without-copyright-information", we
probably need to add a catch-all "Files: *" block (and a separate
"Files: debian/*" block).

Then we need to decide whether we're going to have a patch in
"debian/patches" for patching out those donate links, or whether we're
going to have something do it in debian/rules -- I'm personally OK
with creating and maintaining a patch for that in debian/patches since
that'll be the least invasive change from the perspective of the files
you've got in the upstream tarballs for "debian/" (so that your own
packages are unaffected and this patch will only be for the Debian
archive).

♥,
- Tianon
  4096R / B42F 6819 007F 00F8 8E36  4FD4 036A 9C25 BF35 7DD4


Reply to: