Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG

[Alexandre Detiste <alexandre.detiste@gmail.com>]

Le lundi 9 février 2015, 11:25:11 Simon McVittie a écrit :
> On 08/02/15 18:47, Alexandre Detiste wrote:
> > Thansk for the files, I only needed to remove the references to doom.wad, doom2.wad
> > and nerve.wad; these are already handled by other yaml files.
> 
> Some review:
> 
> +packages:
> ...
> +    install_to: usr/share/games/dhewm3
> 
> I would rather have new games consistently install their data to the
> default location (/usr/share/games/PACKAGENAME)

I agree, but this "-data" in package name sounds completely extraneous,
why not use "/usr/share/games/PACKAGENAME".rstrip('-data') instead as default ?

This would stick with what the other games do;
even the free ones like neverball-data for exampe.

tchet@antec:~$ ls /usr/share/games/ | wc -l
56
tchet@antec:~$ ls /usr/share/games/ -l | grep data
drwxr-xr-x  3 root root 20480 jan 22 18:43 game-data-packager
drwxr-xr-x  4 root root  4096 jan 13 22:57 quake3-data
drwxr-xr-x  3 root root  4096 jan 28 12:37 quake3-team-arena-data
drwxr-xr-x  3 root root  4096 déc 31 12:08 rtcw-data

(and quake3-data is a link-farmed from quake3 anyway) 

> engine-agnostic location
ok, so doom3.yaml should be changed and the two engines too.

> In this case I think I would have both D3 and D3:ROE install to
> usr/share/games/doom3-data, and have D3:BFG install to
> usr/share/games/doom3-bfg-data.