[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#760188: ITP: scoop -- concurrent parallel programmming library



Thanks for more comments.

On 03.09.2014 15:20, PICCA Frederic-Emmanuel wrote:
can you look with the upstream to add copyright headers where it is missing UNKOWN
and it would be nice to have also the copyright in each header.
it seems thaht there is only the license without the copyright statement.

I'll suggest that by occasion.

> /tmp/scoop-0.7.1$ licensecheck -r *

I've checked the files again and added discovery/minusconf.py to deb/copyright.

the sourc epacakge contain already build documentation.
for exemple the
doc/_static directory contain .js code which is part of sphinx, you should indicate this in the copyright file.
Or better ask the upstream to remove this prebuild documentation.

Added copyright info for doc/_static/sidebar.js.

> what about _static/copybutton.js ?

Can't find anything special on this (among other packages only to be found in python{2.7,3.2}-doc [1]), so I suggest we just leave it out (contains no copyright info, whatsoever)

[1] https://packages.debian.org/search?searchon=contents&keywords=copybutton.js&mode=exactfilename&suite=stable&arch=any

* doc/blu.diff ??? this should be removed from the source package.

Not very clean the tarball. Added to the list of comments.

> * doc/_template/* sphinx
>
> * doc/_themes/* ???

Added _template/globaltoc.html to deb/copyright, contains a copyright header.

it sems thah some files hase the DEAP license header. This should be fixed by the upstream or indicated in the copyright file.

picca@ORD03037:/tmp/scoop-0.7.1$ rgrep DEAP *
examples/deap_ga_onemax.py:    raise Exception("This test needs DEAP to be installed.")
examples/dependency/sortingnetwork.py:#    This file is part of DEAP.
examples/dependency/sortingnetwork.py:#    DEAP is free software: you can redistribute it and/or modify
examples/dependency/sortingnetwork.py:#    DEAP is distributed in the hope that it will be useful,
examples/dependency/sortingnetwork.py:#    License along with DEAP. If not, see <http://www.gnu.org/licenses/>.

I'll add that to the comments list. The license matches, though.

* In scoop/backports a few files where copyed from python something can you clarify this ?
   exemple: ./backports/runpy.py

dictconfig.py: added that to deb/copyright, the old Python license is researched.

runpy.py: no copyright and no date are given. I've researched the year and added the source for the info. Can't tell if this entry is problematic, but cme-check doesn't complain.

thanks for your efforts.

Frederic

Further comments welcome.

Setup for autopkgtest is coming up.

Greetings,
Daniel

--
https://qa.debian.org/developer.php?login=debian%40danielstender.com
PGP key: 2048R/E41BD2D0
C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0


Reply to: