[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#711833: [support@mentors.debian.net: postr uploaded to mentors.debian.net]



Hello,

I fixed the desktop-entry-lacks-keywords-entry as asked.
Find attached the patch. I used quilt to create my patch : 04-fix_desktop_keywords.patch and then git format to create patch file.


Regards,

PS : have access (push request) to your repository will be easier for me.

Yoann


2014-06-03 22:50 GMT+02:00 Alexander Alemayhu <alexander@bitraf.no>:
On Tue, Jun 03, 2014 at 11:45:27AM +0200, Yoann Gauthier wrote:
> Hi Alexander,
>
> What are the next tasks I can do to help for the packaging ?
>

You could look at the desktop-entry-lacks-keywords-entry[0] lintian tag and try
to fix it. I was planning on fixing it but wanted to prioritize the autotools
warnings. Hopefully we can get some advice from David.

It looks like you would need to create a debian patch file to modify
data/postr.desktop.in.in. If you are unfamiliar with quilt, take a look at this
introduction[1].

PS: Remember to fetch the latest changes, before making new changes. It might
help in avoiding merge conflicts.

PPS: desktop-entry-lacks-keywords-entry only occurs when using `lintian -EvIL
+pedantic` on my machine.

[0]: http://lintian.debian.org/tags/desktop-entry-lacks-keywords-entry.html
[1]:
http://raphaelhertzog.com/2012/08/08/how-to-use-quilt-to-manage-patches-in-debian-packages/

> Regards,
>
> Yoann
>
>
> 2014-06-02 21:26 GMT+02:00 Alexander Alemayhu <alexander@bitraf.no>:
>
> > On Mon, Jun 02, 2014 at 10:30:40AM +0200, Yoann Gauthier wrote:
> > > Hi,
> > >
> > > For man page license, I propose to distribute it under GNU GLP (v3). Do
> > you
> > > agree ?
> > >
> >
> > I am no license expert, but I think it is okay assuming you mean GNU GPL.
> >
> > > Okay for the maintener part, I will set the maintainer to Python
> > > Applications Packaging Team.
> > >
> > > Regards,
> > >
> > > Yoann
> > >
> > >
> > > 2014-06-01 18:26 GMT+02:00 Alexander Alemayhu <alexander@bitraf.no>:
> > >
> > > > On Sun, Jun 01, 2014 at 03:50:27PM +0200, Yoann Gauthier wrote:
> > > > > Le 31 mai 2014 20:00, "Alexander Alemayhu" <alexander@bitraf.no> a
> > > > écrit :
> > > > > >
> > > > > > On Sat, May 31, 2014 at 03:29:16PM +0200, Yoann Gauthier wrote:
> > > > > > > Hello,
> > > > > > >
> > > > > >
> > > > > > Hei,
> > > > > >
> > > > > > > I wrote the man page (attachment). I have no access to the
> > repository
> > > > > > > today, I will upload the page to repository tomorrow.
> > > > > > >
> > > > > >
> > > > > > Nice. I decided to use github as the Vcs-* since collab-maint
> > seems to
> > > > be
> > > > > for
> > > > > > people packing together with DDs. Maybe we should ask for access
> > and
> > > > push
> > > > > our
> > > > > > changes there?
> > > > >
> > > > > I don't understand Vcs, what is it ?
> > > >
> > > > A akronym for Version Control System[0].
> > > >
> > > > > > I think you have a typo 'MAINTENERS' should be 'MAINTAINERS'. It
> > could
> > > > be
> > > > > a
> > > > > > good idea to ask for others to review the man page. Which license
> > do
> > > > you
> > > > > want
> > > > > > to distribute the man page with? we have to mention the license in
> > > > > > debian/copyright.
> > > > >
> > > > > Agree for the typo, this evening I will read again the man page and
> > add
> > > > > more information maybe. Okay for the license, i will think.
> > > > > >
> > > >
> > > > In order to stay consistent with the debian/control file we should set
> > the
> > > > maintainer to Python Applications Packaging Team
> > > > <python-apps-team@lists.alioth.debian.org>
> > > >
> > > > > > > Regards,
> > > > > > >
> > > > > > > Yoann
> > > > > > >
> > > >
> > > > [0]: http://en.wikipedia.org/wiki/Version_control
> > > >
> > > > > > >
> > > > > > > 2014-05-30 12:36 GMT+02:00 Yoann Gauthier <
> > yoann.gauthier9@gmail.com
> > > > >:
> > > > > > >
> > > > > > > > Hi Alexander,
> > > > > > > >
> > > > > > > > Yes, I am going to write the man page. It will be finished
> > today or
> > > > > > > > tomorrow.
> > > > > > > > Okay for the RFS.
> > > > > > > >
> > > > > > > > Regards,
> > > > > > > >
> > > > > > > > Yoann
> > > > > > > >
> > > > > > > >
> > > > > > > > 2014-05-30 10:43 GMT+02:00 Alexander Alemayhu <
> > alexander@bitraf.no
> > > > >:
> > > > > > > >
> > > > > > > > Hei Yoann,
> > > > > > > >>
> > > > > > > >> below is a message I recived after reuploading to
> > > > mentors.debian.net.
> > > > > > > >> The warnings I mentioned earlier are visible in the package
> > page.
> > > > > > > >> Are you going to write a man page? I would like to send a RFS
> > > > after
> > > > > fixing
> > > > > > > >> some more of the warnings to the PAPT list.
> > > > > > > >>
> > > > > > > >> ----- Forwarded message from "mentors.debian.net" <
> > > > > > > >> support@mentors.debian.net> -----
> > > > > > > >>
> > > > > > > >> Date: Wed, 28 May 2014 21:33:31 +0000 (UTC)
> > > > > > > >> From: "mentors.debian.net" <support@mentors.debian.net>
> > > > > > > >> To: alexander@bitraf.no
> > > > > > > >> Subject: postr uploaded to mentors.debian.net
> > > > > > > >>
> > > > > > > >> Hi.
> > > > > > > >>
> > > > > > > >> Your upload of the package 'postr' to mentors.debian.net was
> > > > > > > >> successful. Others can now see it. The URL of your package is:
> > > > > > > >> http://mentors.debian.net/package/postr
> > > > > > > >>
> > > > > > > >> The respective dsc file can be found at:
> > > > > > > >>
> > > > http://mentors.debian.net/debian/pool/main/p/postr/postr_0.13-1.dsc
> > > > > > > >>
> > > > > > > >> If you do not yet have a sponsor for your package you may
> > want to
> > > > go
> > > > > to
> > > > > > > >> http://mentors.debian.net/sponsors/rfs-howto/postr
> > > > > > > >> and set the "Seeking a sponsor" option to highlight your
> > package
> > > > on
> > > > > the
> > > > > > > >> welcome page.
> > > > > > > >>
> > > > > > > >> You can also send an RFS (request for sponsorship) to the
> > > > > debian-mentors
> > > > > > > >> mailing list. Your package page will give your suggestions on
> > how
> > > > to
> > > > > > > >> send that mail.
> > > > > > > >>
> > > > > > > >> Good luck in finding a sponsor!
> > > > > > > >>
> > > > > > > >> Thanks,
> > > > > > > >>
> > > > > > > >> --
> > > > > > > >> mentors.debian.net
> > > > > > > >>
> > > > > > > >> ----- End forwarded message -----
> > > > > > > >>
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > > >
> > > >
> >

From 6f2a4a41373d5b029e552fbf47fecd944bf6a25d Mon Sep 17 00:00:00 2001
From: Yoann Gauthier <yoann.gauthier9@gmail.com>
Date: Mon, 9 Jun 2014 20:24:03 +0200
Subject: [PATCH 2/2] Fix desktop-entry-lacks-keywords-entry lintian tag

---
 debian/patches/04-fix_desktop_keywords.patch |   13 +++++++++++++
 debian/patches/series                        |    1 +
 2 files changed, 14 insertions(+)
 create mode 100644 debian/patches/04-fix_desktop_keywords.patch

diff --git a/debian/patches/04-fix_desktop_keywords.patch b/debian/patches/04-fix_desktop_keywords.patch
new file mode 100644
index 0000000..9e5a24c
--- /dev/null
+++ b/debian/patches/04-fix_desktop_keywords.patch
@@ -0,0 +1,13 @@
+Description: Fix Desktop Keyword warning
+ Fix desktop-entry-lacks-keywords-entry lintian tag for clean package
+Author: Yoann Gauthier <yoann.gauthier9@gmail.com>
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/data/postr.desktop.in.in
++++ b/data/postr.desktop.in.in
+@@ -13,3 +13,4 @@
+ X-GNOME-Bugzilla-Product=postr
+ X-GNOME-Bugzilla-Component=general
+ X-GNOME-Bugzilla-Version=@VERSION@
++_Keywords=flickr;upload;picture;postr;image;tool;gnome;
+\ No newline at end of file
diff --git a/debian/patches/series b/debian/patches/series
index a78f286..bc61a4f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@
 01-fix_encoding.patch
 02-fix-glade-path.patch
 03-handle-python-bytecode-compilation.patch
+04-fix_desktop_keywords.patch
-- 
1.7.10.4


Reply to: