Bug#735884: RFS: ocp-indent -- OCaml indentation tool for emacs and vim
Le 27/02/2014 12:24, Johannes Schauer a écrit :
>> Have you considered joining the OCaml team on Alioth[1], and put your
>> packaging as a git repository there[2]?
>>
>> [1] https://alioth.debian.org/projects/pkg-ocaml-maint/
>> [2] dom-new-git-repo(1), in package dh-ocaml
>
> I committed my current status of packaging to ocp-intent.git
Good.
>> I started to have a look, and for sure the copyright file is incorrect.
>> There is a lot of copyright to "Jun Furuse" and OCamlPro, those two should at
>> least be mentioned. Actually, I didn't see (after a quick look) any copyright
>> owned by the ones you mentioned in debian/copyright (Thomas and Fabrice work
>> for OCamlPro and/or Inria, but the copyright seems to belong to the company
>> and Inria). There are also some other bits from other people, you have to be
>> sure that at least license is the same.
>
> The copyright issue has now been clarified by upstream [1] and I integrated it
> into debian/copyright.
Good.
>> I am still reviewing the technical part, but I preferred to tell you about
>> the copyright issue first.
>>
>> Thank you for your contribution!
>
> I hope the packaging is not too bad. Please tell me the things that are left to
> fix.
Why do you add libocp-indent-lib-ocaml as explicit dependency to
ocp-indent? Isn't the one inferred by dh_ocaml enough?
If you put META and $foo.cma in a runtime package, there should also be
$foo.cmxs there (on native architectures). Otherwise, not having a
runtime package at all is fine for pure OCaml libraries.
There are no *.cmx files installed. Do you know if that's intentional?
Cheers,
--
Stéphane
Reply to: