Bug#615158: ITP: ocaml-cil -- OCaml library for manipulating C programs

[Gabriel Kerneis <gabriel@kerneis.info>]

On Wed, Oct 09, 2013 at 12:30:12PM +0200, Stéphane Glondu wrote:
> In the sources, the doc/cilcode.tmp directory looks suspicious. It
> contains many .o files. Shouldn't it be removed?

Indeed, I have no idea how it was included but it is (re)generated by
make doc so I'll make sure it is removed.

> The OCaml library (/usr/lib/ocaml/cil) must be in its own binary package
> (libcil-ocaml-dev) with a Provides field, so that reverse dependencies
> get their dependencies right.

OK.  Fedora also uses separate packages for ocaml-cil-doc and
ocaml-cil-cilly; is this also required for Debian?

> Is is really needed to have cilly.byte AND cilly.native?

The perl wrapper script bin/cilly provides a --bytecode flag to invoke
the bytecode version.  I'm not sure about the historical motivation for
this (ocamldebug comes to mind), but I am reluctant to potentially break
existing user workflows just for the sake saving 1.3 MB.

> Please set the Maintainer field to "Debian OCaml Maintainers <...>" and
> move your name to an Uploaders field.

OK.

I'll let you know when a new version is available.

Thanks for your review,
-- 
Gabriel