[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#628997: gecko-mediaplayer maintenance



On Tue, Jan 3, 2012 at 09:06, Sebastian Ramacher <s.ramacher@gmx.at> wrote:
> On 01/02/2012 02:43 PM, Aron Xu wrote:
>> I'm afraid you'd import from the PPA.
>
> Done. Furthermore I've incorporated, amongst others, the following changes to gmtk:
>  * Enabled hardened build flags.
>  * Converted the package to Multi-Arch and ship the translation files.
>  * Added a patch from upstream to fix issues with missing symbols.
>  * Added symbols files for both libraries.
>  * Set the Maintainer to Debian Multimedia Team and added Brandon and myself to
> Uploaders.
>  * Fixed all the issues reported by lintian (except for
> unversioned-copyright-format-uri).
>

Great work!

> I didn't have a look at debian/copyright so far. I plan to do that tomorrow.
>
> I've also started to work on gecko-mediaplayer 1.0.5:
>  * Imported Brandon's work.
>  * Enabled hardened build flags.
>  * Dropped the dependencies on specific browsers.
>
> I'd appreciate comments on the state of gmtk so that we can get it uploaded
> soon. And there is one issue that is bugging me: libgmlib and libgmtk both
> export symbols that should be private [1]. Any thoughts on that?
>
> Kind regards,
>
> [1] https://code.google.com/p/gmtk/issues/detail?id=4&can=1
> --
> Sebastian Ramacher
>

1.I'm wondering whether we should enable GTK+ 3 support for all the
packages, which has been requested[1].
2.You have disabled the generation of static library, which I'm
curious about the reason. You can safely ship those
files in -dev packages.
3.For symbols that should be private, it would be okay to patch the
build system to add a library version script,
so you can control which symbols are exported without touching many
source files.
4. It would be better not to override
package-needs-versioned-debhelper-build-depends, so it can remind us
to update Build-Dep
field when debhelper 9 is out.

[1]https://bugs.launchpad.net/ubuntu/+source/gnome-mplayer/+bug/817933

-- 
Regards,
Aron Xu



Reply to: