[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#650734: ITP tupi update

[Cutting down debian-kernel@l.d.o from CC.]

On Tue, Jan 24, 2012 at 01:54, Dmitry Smirnov <onlyjob@member.fsf.org> wrote:
> Hi Aron,
> Thank you for fantastic review.
> I addressed all the issues in the updated package available from
>  http://mentors.debian.net/debian/pool/main/t/tupi/tupi_0.1+git12-1.dsc
> [data is separated into tupi-data package; dpkg-shlibdeps has been given path
> to plugins]
> Please ignore minor lintian warning regarding desktop-entry-contains-encoding-
> key: some time ago upstream fixed it, according to my suggestion.
> Regards,
> Dmitry.

Thanks for your hard work! But I believe there are more work needs to be done:

1.In /usr/bin, there are tupi.bin and tupi, the first one is the
actual binary and the latter a launcher script. At such situation, I
would like to recommend you move tupi.bin to /usr/lib/tupi/. You can
have a look at how the iceweasel and xulrunner-9.0 packages are

2.For file in 3rdparty/potrace/, it's not sufficient to use "Files:
3rdparty/potrace" to describe them in DEP5 copyright, please use
something like "3rdparty/potrace/*" instead.

3.Files in 3rdparty/quazip/, at least crypt.h, zip.* and unzip.*, are
licensed under different license than GPL-3, please add them to

4.It would be the best if you put documentations (KNOWN_BUGS, README)
to tupi-data, because they are also arch-indep.

The application itself works fine for me.

Aron Xu

Reply to: