Bug#647090: Review for the package on mentors.debian.net

[Aron Xu <happyaron.xu@gmail.com>]

Hi Michael,

I had a quick look at your package on mentors.debian.net, and here are
my comments:

1.As you have updated the package to use debhelper compatible level 8,
the use of source format 3.0 is highly recommended. What you need to
do is:
$ mkdir debian/source
$ echo "3.0 (quilt)" > debian/source/format
Then review your patches against the build system (*/config.[mk,h])
and make them maintained using quilt in debian/patches/ .

2.Can you explain why usr/bin/slock should be setuid? I can guess that
it's an screen locker so it may need the privilege to do its job, but
since it is a potential security hole please document it in
README.Debian for it.

3.The file debian/copyright isn't old style, nor following DEP-5. You
may modify it to follow DEP-5 standard, which can be found at
http://dep.debian.net/deps/dep5

4.debian/watch is missing. If you can, please add a watch file.

5.Man page wmname.1 has a spelling error: "similiar" should be "similar".


-- 
Regards,
Aron Xu